Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2656163002: DevTools: fix network waterfall sorting icon (Closed)

Created:
3 years, 10 months ago by allada
Modified:
3 years, 10 months ago
Reviewers:
dgozman, lushnikov, allada
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

DevTools: fix network waterfall sorting icon This patch: - hides network waterfall sorting icon if other column is used for sorting - makes icon crisp on retina BUG=684894 R=dgozman, allada NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2652893008 Cr-Commit-Position: refs/heads/master@{#445921} (cherry picked from commit 4fad6cb6f585cdfeaccf613a9c310f04260c87c3) Review-Url: https://codereview.chromium.org/2656163002 Cr-Commit-Position: refs/branch-heads/2987@{#120} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/260197f0c30569f1aa843393c10a96e9ab957cb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/networkLogView.css View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
allada
PTL
3 years, 10 months ago (2017-01-26 20:57:24 UTC) #2
dgozman
lgtm
3 years, 10 months ago (2017-01-26 20:58:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656163002/1
3 years, 10 months ago (2017-01-26 21:00:07 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 21:03:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/260197f0c30569f1aa843393c10a...

Powered by Google App Engine
This is Rietveld 408576698