Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2656003004: Remember user decision for bad ssl certs. (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remember user decision for bad ssl certs. Call registerAllowedCertificate:forHost:status: when user accepted bad SSL cert in the same way as Request Tracker did: https://codereview.chromium.org/2648763002/patch/1/10002 BUG=685745 Review-Url: https://codereview.chromium.org/2656003004 Cr-Commit-Position: refs/heads/master@{#446989} Committed: https://chromium.googlesource.com/chromium/src/+/a8475d7892c2333e06372af29d1648e550d72ed8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
This is something that we can't EG test, I will ask Claude if we can ...
3 years, 10 months ago (2017-01-27 19:26:58 UTC) #2
sdefresne
lgtm
3 years, 10 months ago (2017-01-30 09:05:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656003004/1
3 years, 10 months ago (2017-01-30 15:38:59 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 15:52:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8475d7892c2333e06372af29d16...

Powered by Google App Engine
This is Rietveld 408576698