Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2648763002: CRWWebController no longer implements CRWRequestTrackerDelegate. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/ui/crw_web_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 852fd1f5b64e34c26d8f3ff36847ba4d56ff3b5b..c035b4befecc87b149da90b5183c6d37af97a99b 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -3487,63 +3487,6 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
}
#pragma mark -
-#pragma mark CRWRequestTrackerDelegate
-
-- (void)updatedSSLStatus:(const web::SSLStatus&)sslStatus
- forPageUrl:(const GURL&)url
- userInfo:(id)userInfo {
- // |userInfo| is a CRWSessionEntry.
- web::NavigationItem* item =
- [static_cast<CRWSessionEntry*>(userInfo) navigationItem];
- if (!item)
- return; // This is a request update for an entry that no longer exists.
-
- // This condition happens infrequently when a page load is misinterpreted as
- // a resource load from a previous page. This can happen when moving quickly
- // back and forth through history, the notifications from the web view on the
- // UI thread and the one from the requests at the net layer may get out of
- // sync. This catches this case and prevent updating an entry with the wrong
- // SSL data.
- if (item->GetURL().GetOrigin() != url.GetOrigin())
- return;
-
- if (item->GetSSL().Equals(sslStatus))
- return; // No need to update with the same data.
-
- item->GetSSL() = sslStatus;
-
- // Notify the UI it needs to refresh if the updated entry is the current
- // entry.
- if (userInfo == self.currentSessionEntry) {
- [self didUpdateSSLStatusForCurrentNavigationItem];
- }
-}
-
-- (void)handleResponseHeaders:(net::HttpResponseHeaders*)headers
- requestUrl:(const GURL&)requestUrl {
- _webStateImpl->OnHttpResponseHeadersReceived(headers, requestUrl);
-}
-
-- (void)updatedProgress:(float)progress {
- // This is a UIWebView callback, which is no longer called.
- NOTREACHED();
-}
-
-- (void)certificateUsed:(net::X509Certificate*)certificate
- forHost:(const std::string&)host
- status:(net::CertStatus)status {
- [[[self sessionController] sessionCertificatePolicyManager]
- registerAllowedCertificate:certificate
- forHost:host
- status:status];
-}
-
-- (void)clearCertificates {
- [[[self sessionController] sessionCertificatePolicyManager]
- clearCertificates];
-}
-
-#pragma mark -
#pragma mark Popup handling
- (BOOL)shouldBlockPopupWithURL:(const GURL&)popupURL
« no previous file with comments | « ios/web/web_state/ui/crw_web_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698