Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2655963006: Implemented StructTraits for cc::CopyOutputRequest (Closed)

Created:
3 years, 10 months ago by Saman Sami
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, cc-bugs_chromium.org, chromium-reviews, darin (slow to review), miu+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implemented StructTraits for cc::CopyOutputRequest MojoCompositorFrameSink needs to support copy requests, which means we need mojo definition and struct traits for cc::CopyOutputRequests in order to send it over mojo. BUG=672071 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2655963006 Cr-Commit-Position: refs/heads/master@{#447277} Committed: https://chromium.googlesource.com/chromium/src/+/345632b5cbddaa65124eb98bce6fa933fa211c35

Patch Set 1 #

Patch Set 2 : c #

Patch Set 3 : c #

Patch Set 4 : c #

Total comments: 1

Patch Set 5 : c #

Patch Set 6 : c #

Patch Set 7 : c #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -22 lines) Patch
M cc/ipc/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A cc/ipc/copy_output_request.mojom View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
A cc/ipc/copy_output_request.typemap View 1 chunk +11 lines, -0 lines 0 comments Download
A cc/ipc/copy_output_request_struct_traits.h View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 1 2 3 4 5 6 4 chunks +51 lines, -0 lines 0 comments Download
M cc/ipc/traits_test_service.mojom View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M cc/ipc/typemaps.gni View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A cc/output/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/output/copy_output_request.h View 1 2 3 4 4 chunks +18 lines, -13 lines 0 comments Download
M cc/output/copy_output_request.cc View 1 2 3 4 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 46 (35 generated)
Saman Sami
PTAL
3 years, 10 months ago (2017-01-30 22:33:06 UTC) #16
Fady Samuel
lgtm
3 years, 10 months ago (2017-01-30 23:56:58 UTC) #19
Saman Sami
enne@: Please review cc/ tsepez@: Please review mojo
3 years, 10 months ago (2017-01-31 00:52:51 UTC) #21
Saman Sami
sky: Please review cc/output/DEPS
3 years, 10 months ago (2017-01-31 15:31:04 UTC) #25
Saman Sami
PTAL
3 years, 10 months ago (2017-01-31 15:31:15 UTC) #26
Tom Sepez
lgtm
3 years, 10 months ago (2017-01-31 16:46:34 UTC) #29
Fady Samuel
Please add a short description WHY you're adding StructTraits for our future reference. Thanks!
3 years, 10 months ago (2017-01-31 17:02:53 UTC) #34
sky
LGTM
3 years, 10 months ago (2017-01-31 18:23:31 UTC) #38
enne (OOO)
lgtm https://codereview.chromium.org/2655963006/diff/60001/cc/ipc/copy_output_request.mojom File cc/ipc/copy_output_request.mojom (right): https://codereview.chromium.org/2655963006/diff/60001/cc/ipc/copy_output_request.mojom#newcode10 cc/ipc/copy_output_request.mojom:10: // TODO(samans): Add source. In general, I was ...
3 years, 10 months ago (2017-01-31 18:24:47 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655963006/120001
3 years, 10 months ago (2017-01-31 18:27:32 UTC) #43
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 18:34:45 UTC) #46
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/345632b5cbddaa65124eb98bce6f...

Powered by Google App Engine
This is Rietveld 408576698