Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2461)

Unified Diff: cc/output/copy_output_request.h

Issue 2655963006: Implemented StructTraits for cc::CopyOutputRequest (Closed)
Patch Set: c Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/DEPS ('k') | cc/output/copy_output_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/copy_output_request.h
diff --git a/cc/output/copy_output_request.h b/cc/output/copy_output_request.h
index 6df8ba8a67f1bb49aace54c772ee38a74daf2340..2bc0b4d0c7b244f716cf0df8c3afa77ecc3e4dbb 100644
--- a/cc/output/copy_output_request.h
+++ b/cc/output/copy_output_request.h
@@ -14,11 +14,17 @@
#include "cc/base/cc_export.h"
#include "cc/resources/single_release_callback.h"
#include "cc/resources/texture_mailbox.h"
+#include "mojo/public/cpp/bindings/struct_traits.h"
#include "ui/gfx/geometry/rect.h"
class SkBitmap;
namespace cc {
+
+namespace mojom {
+class CopyOutputRequestDataView;
+}
+
class CopyOutputResult;
class CC_EXPORT CopyOutputRequest {
@@ -41,6 +47,8 @@ class CC_EXPORT CopyOutputRequest {
const CopyOutputRequest& original_request,
const CopyOutputRequestCallback& result_callback);
+ CopyOutputRequest();
+
~CopyOutputRequest();
bool IsEmpty() const { return result_callback_.is_null(); }
@@ -57,19 +65,16 @@ class CC_EXPORT CopyOutputRequest {
// By default copy requests copy the entire layer's subtree output. If an
// area is given, then the intersection of this rect (in layer space) with
// the layer's subtree output will be returned.
- void set_area(const gfx::Rect& area) {
- has_area_ = true;
- area_ = area;
- }
- bool has_area() const { return has_area_; }
- gfx::Rect area() const { return area_; }
+ void set_area(const gfx::Rect& area) { area_ = area; }
+ bool has_area() const { return area_.has_value(); }
+ const gfx::Rect& area() const { return *area_; }
// By default copy requests create a new TextureMailbox to return contents
// in. This allows a client to provide a TextureMailbox, and the compositor
// will place the result inside the TextureMailbox.
void SetTextureMailbox(const TextureMailbox& texture_mailbox);
- bool has_texture_mailbox() const { return has_texture_mailbox_; }
- const TextureMailbox& texture_mailbox() const { return texture_mailbox_; }
+ bool has_texture_mailbox() const { return texture_mailbox_.has_value(); }
+ const TextureMailbox& texture_mailbox() const { return *texture_mailbox_; }
void SendEmptyResult();
void SendBitmapResult(std::unique_ptr<SkBitmap> bitmap);
@@ -81,16 +86,16 @@ class CC_EXPORT CopyOutputRequest {
void SendResult(std::unique_ptr<CopyOutputResult> result);
private:
- CopyOutputRequest();
+ friend struct mojo::StructTraits<mojom::CopyOutputRequestDataView,
+ CopyOutputRequest>;
+
CopyOutputRequest(bool force_bitmap_result,
const CopyOutputRequestCallback& result_callback);
base::Optional<base::UnguessableToken> source_;
bool force_bitmap_result_;
- bool has_area_;
- bool has_texture_mailbox_;
- gfx::Rect area_;
- TextureMailbox texture_mailbox_;
+ base::Optional<gfx::Rect> area_;
+ base::Optional<TextureMailbox> texture_mailbox_;
CopyOutputRequestCallback result_callback_;
};
« no previous file with comments | « cc/output/DEPS ('k') | cc/output/copy_output_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698