Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2655853007: Convert ChromeExtensionWebContentsObserver to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ChromeExtensionWebContentsObserver to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2655853007 Cr-Commit-Position: refs/heads/master@{#446738} Committed: https://chromium.googlesource.com/chromium/src/+/78581ca34da7bc45e77c686048408fe640f09945

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M chrome/browser/extensions/chrome_extension_web_contents_observer.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/chrome_extension_web_contents_observer.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M extensions/browser/extension_web_contents_observer.h View 1 chunk +2 lines, -4 lines 0 comments Download
M extensions/browser/extension_web_contents_observer.cc View 1 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jam
3 years, 10 months ago (2017-01-26 23:40:41 UTC) #5
Devlin
lgtm https://codereview.chromium.org/2655853007/diff/1/extensions/browser/extension_web_contents_observer.cc File extensions/browser/extension_web_contents_observer.cc (right): https://codereview.chromium.org/2655853007/diff/1/extensions/browser/extension_web_contents_observer.cc#newcode169 extensions/browser/extension_web_contents_observer.cc:169: // Should have been unregistered by DidCommitNavigation. s/DidCommitNavigation/DidFinishNavigation
3 years, 10 months ago (2017-01-27 18:15:27 UTC) #8
jam
https://codereview.chromium.org/2655853007/diff/1/extensions/browser/extension_web_contents_observer.cc File extensions/browser/extension_web_contents_observer.cc (right): https://codereview.chromium.org/2655853007/diff/1/extensions/browser/extension_web_contents_observer.cc#newcode169 extensions/browser/extension_web_contents_observer.cc:169: // Should have been unregistered by DidCommitNavigation. On 2017/01/27 ...
3 years, 10 months ago (2017-01-27 19:06:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655853007/20001
3 years, 10 months ago (2017-01-27 19:07:18 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 19:53:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/78581ca34da7bc45e77c68604840...

Powered by Google App Engine
This is Rietveld 408576698