Convert ChromeExtensionWebContentsObserver to use the new navigation callbacks.

Convert ChromeExtensionWebContentsObserver to use the new navigation callbacks.

BUG=682002
Review-Url: https://codereview.chromium.org/2655853007
Cr-Commit-Position: refs/heads/master@{#446738}
Committed: https://chromium.googlesource.com/chromium/src/+/78581ca34da7bc45e77c686048408fe640f09945

[jam, 2017-01-26 23:06:42]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 23:07:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-26 23:09:30]

Description was changed from

==========
Convert ChromeExtensionWebContentsObserver to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert ChromeExtensionWebContentsObserver to use the new navigation callbacks.

BUG=682002
==========

[jam, 2017-01-26 23:09:30]

jam@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:07:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:07:32]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-01-27 18:15:27]

lgtm

https://codereview.chromium.org/2655853007/diff/1/extensions/browser/extensio...
File extensions/browser/extension_web_contents_observer.cc (right):

https://codereview.chromium.org/2655853007/diff/1/extensions/browser/extensio...
extensions/browser/extension_web_contents_observer.cc:169: // Should have been
unregistered by DidCommitNavigation.
s/DidCommitNavigation/DidFinishNavigation

[jam, 2017-01-27 19:06:35]

https://codereview.chromium.org/2655853007/diff/1/extensions/browser/extensio...
File extensions/browser/extension_web_contents_observer.cc (right):

https://codereview.chromium.org/2655853007/diff/1/extensions/browser/extensio...
extensions/browser/extension_web_contents_observer.cc:169: // Should have been
unregistered by DidCommitNavigation.
On 2017/01/27 18:15:26, Devlin (catching up) wrote:
> s/DidCommitNavigation/DidFinishNavigation

Done.

[jam, 2017-01-27 19:06:48]

The CQ bit was checked by jam@chromium.org

[jam, 2017-01-27 19:06:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2655853007/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2017-01-27 19:07:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 19:52:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485544008347110,
"parent_rev": "903b184b89b72ecd31d33989165fd8cf11843410", "commit_rev":
"78581ca34da7bc45e77c686048408fe640f09945"}

[commit-bot: I haz the power, 2017-01-27 19:53:27]

Description was changed from

==========
Convert ChromeExtensionWebContentsObserver to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert ChromeExtensionWebContentsObserver to use the new navigation callbacks.

BUG=682002

Review-Url: https://codereview.chromium.org/2655853007
Cr-Commit-Position: refs/heads/master@{#446738}
Committed:
https://chromium.googlesource.com/chromium/src/+/78581ca34da7bc45e77c68604840...
==========

[commit-bot: I haz the power, 2017-01-27 19:53:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/78581ca34da7bc45e77c68604840...