extensions/browser/extension_web_contents_observer.h - Issue 2655853007: Convert ChromeExtensionWebContentsObserver to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_web_contents_observer.h

Issue 2655853007: Convert ChromeExtensionWebContentsObserver to use the new navigation callbacks. (Closed)

Patch Set: nit Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/extension_web_contents_observer.h

diff --git a/extensions/browser/extension_web_contents_observer.h b/extensions/browser/extension_web_contents_observer.h

index 2c15333c47dc1172bb1acd22099e46c43491341d..f96d7c9af44100041dbbff220bb03d2f5c942469 100644

--- a/extensions/browser/extension_web_contents_observer.h

+++ b/extensions/browser/extension_web_contents_observer.h

@@ -86,10 +86,8 @@ class ExtensionWebContentsObserver

void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;

void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override;

- void DidCommitProvisionalLoadForFrame(

- content::RenderFrameHost* render_frame_host,

- const GURL& url,

- ui::PageTransition transition_type) override;

+ void DidFinishNavigation(

+ content::NavigationHandle* navigation_handle) override;

void DidNavigateAnyFrame(content::RenderFrameHost* render_frame_host,

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) override;