Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 2655843002: Make remaining dart2js unit tests pass. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/fasta
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M pkg/compiler/lib/src/parser/diet_parser_task.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
I mixed up the meaning of PartialParser in CL 2651843004 so I've switch back to ...
3 years, 11 months ago (2017-01-25 10:00:22 UTC) #2
Johnni Winther
lgtm
3 years, 11 months ago (2017-01-25 11:10:50 UTC) #3
ahe
3 years, 11 months ago (2017-01-25 12:10:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
12a44f152f1ec226aa3711e105b7b10db7aed16d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698