Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2654433009: Skeleton for lexical error recovery. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, lukechurch, Brian Wilkerson
Target Ref:
refs/heads/fasta
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M pkg/dart_scanner/lib/dart_scanner.dart View 1 3 chunks +17 lines, -2 lines 0 comments Download
M pkg/dart_scanner/lib/src/abstract_scanner.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/dart_scanner/lib/src/array_based_scanner.dart View 2 chunks +3 lines, -0 lines 0 comments Download
A pkg/dart_scanner/lib/src/recover.dart View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ahe
3 years, 11 months ago (2017-01-25 09:17:20 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/2654433009/diff/20001/pkg/dart_scanner/lib/dart_scanner.dart File pkg/dart_scanner/lib/dart_scanner.dart (right): https://codereview.chromium.org/2654433009/diff/20001/pkg/dart_scanner/lib/dart_scanner.dart#newcode67 pkg/dart_scanner/lib/dart_scanner.dart:67: if (scanner.hasErrors && recover != null) { Remove ...
3 years, 11 months ago (2017-01-25 10:33:59 UTC) #4
ahe
Thank you, Johnni! https://codereview.chromium.org/2654433009/diff/20001/pkg/dart_scanner/lib/dart_scanner.dart File pkg/dart_scanner/lib/dart_scanner.dart (right): https://codereview.chromium.org/2654433009/diff/20001/pkg/dart_scanner/lib/dart_scanner.dart#newcode67 pkg/dart_scanner/lib/dart_scanner.dart:67: if (scanner.hasErrors && recover != null) ...
3 years, 11 months ago (2017-01-25 10:36:21 UTC) #5
ahe
3 years, 11 months ago (2017-01-25 10:39:19 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
a9c208bcb4b22bd873daf8f2e521652f630d5bb4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698