Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2652203002: Make all dart2js language tests pass. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/fasta
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M pkg/compiler/lib/src/parser/element_listener.dart View 4 chunks +11 lines, -6 lines 1 comment Download

Depends on Patchset:

Issue 2655843002 Patch 1

Messages

Total messages: 5 (2 generated)
ahe
https://codereview.chromium.org/2652203002/diff/1/pkg/compiler/lib/src/parser/element_listener.dart File pkg/compiler/lib/src/parser/element_listener.dart (right): https://codereview.chromium.org/2652203002/diff/1/pkg/compiler/lib/src/parser/element_listener.dart#newcode893 pkg/compiler/lib/src/parser/element_listener.dart:893: void reportFatalError(Spannable spannable, String message) { Restoring previous API. ...
3 years, 11 months ago (2017-01-25 10:35:09 UTC) #2
Johnni Winther
lgtm
3 years, 11 months ago (2017-01-25 11:11:47 UTC) #3
ahe
3 years, 11 months ago (2017-01-25 12:11:45 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6d1f13df696700a2640236b8fce69eb18b800229 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698