Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2655793003: Revert of DevTools: Correct Source Panel Show/Hide Toolbar buttons (Closed)

Created:
3 years, 10 months ago by lushnikov
Modified:
3 years, 10 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Correct Source Panel Show/Hide Toolbar buttons (patchset #1 id:1 of https://codereview.chromium.org/2600493002/ ) Reason for revert: It turned out the icons are actually wrong. Compare: - Without this patch (correct): http://imgur.com/a/eFCnz - With this patch (incorrect): http://imgur.com/a/gJ24q Original issue's description: > DevTools: Correct Source Panel Show/Hide Toolbar buttons > > Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is seen in devtools. > > Flipped mask positions and removed—now unnecessary—rotation transforms around show/hide panel icon containers. > > BUG=671930 > R=lushnikov@chromium.org > TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons > are correctly aligned. crbug.com/671930 > > Review-Url: https://codereview.chromium.org/2600493002 > Cr-Commit-Position: refs/heads/master@{#445339} > Committed: https://chromium.googlesource.com/chromium/src/+/4d2364eb32a5b242790324536efccd843cb81aa8 TBR=dgozman@chromium.org,pfeldman@chromium.org,me@jakehendy.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=671930 Review-Url: https://codereview.chromium.org/2655793003 Cr-Commit-Position: refs/heads/master@{#445983} Committed: https://chromium.googlesource.com/chromium/src/+/d52b38109b89d346334cc0bc582328d6131fe720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
lushnikov
Created Revert of DevTools: Correct Source Panel Show/Hide Toolbar buttons
3 years, 10 months ago (2017-01-25 07:17:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655793003/1
3 years, 10 months ago (2017-01-25 07:17:45 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-25 09:12:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d52b38109b89d346334cc0bc5823...

Powered by Google App Engine
This is Rietveld 408576698