DevTools: Correct Source Panel Show/Hide Toolbar buttons

DevTools: Correct Source Panel Show/Hide Toolbar buttons

Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is seen in devtools.

Flipped mask positions and removed—now unnecessary—rotation transforms around show/hide panel icon containers.

BUG=671930
R=lushnikov@chromium.org
TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons
are correctly aligned. crbug.com/671930

Review-Url: https://codereview.chromium.org/2600493002
Cr-Commit-Position: refs/heads/master@{#445339}
Committed: https://chromium.googlesource.com/chromium/src/+/4d2364eb32a5b242790324536efccd843cb81aa8

[Jake Hendy, 2016-12-22 12:15:25]

Description was changed from

==========
Add Jake Hendy to authors and clang-format


DevTools sidebar show-hide buttons

Flipped mask positions and remove now unnecessary transforms

BUG=671930
R=lushnikov@chromium.org
TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons
are correctly aligned. crbug.com/671930
==========

to

==========
Add Jake Hendy to authors and clang-format


DevTools sidebar show-hide buttons

Flipped mask positions and remove now unnecessary transforms

BUG=671930
R=lushnikov@chromium.org
TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons
are correctly aligned. crbug.com/671930
==========

[Jake Hendy, 2016-12-24 22:02:44]

me@jakehendy.com changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[Jake Hendy, 2017-01-21 19:06:35]

Hey guys,

Any update on this CR? :) 

Thanks!

[brucedawson, 2017-01-22 01:28:14]

On 2017/01/21 19:06:35, Jake Hendy wrote:
> Hey guys,
> 
> Any update on this CR? :) 
> 
> Thanks!

Jake - the description needs tweaking. The first line of the description should
match the issue title. It looks like the issue title is correct, so copy that
into the description? Then one blank line. You should probably delete the "Add
Jake Hendy..." line as that is not the focus of the CL.

You might also have more luck with a bit more of an explanation of what this
changes and why. Perhaps some details from the bug? The easier you may it for
the reviewers the better.

[pfeldman1, 2017-01-22 02:40:06]

The change is self-explanatory, no need for more details. We just need to apply
it and check that the images are ok and paddings of the icons remain the same
without rotation.

[Jake Hendy, 2017-01-22 17:22:48]

Description was changed from

==========
Add Jake Hendy to authors and clang-format


DevTools sidebar show-hide buttons

Flipped mask positions and remove now unnecessary transforms

BUG=671930
R=lushnikov@chromium.org
TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons
are correctly aligned. crbug.com/671930
==========

to

==========
Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is
seen in devtools.

Flipped mask positions and removed—now unnecessary—rotation transforms around
show/hide panel icon containers.

BUG=671930
R=lushnikov@chromium.org
TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons
are correctly aligned. crbug.com/671930
==========

[lushnikov, 2017-01-23 05:43:46]

Description was changed from

==========
Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is
seen in devtools.

Flipped mask positions and removed—now unnecessary—rotation transforms around
show/hide panel icon containers.

BUG=671930
R=lushnikov@chromium.org
TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons
are correctly aligned. crbug.com/671930
==========

to

==========
DevTools: Correct Source Panel Show/Hide Toolbar buttons

Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is
seen in devtools.

Flipped mask positions and removed—now unnecessary—rotation transforms around
show/hide panel icon containers.

BUG=671930
R=lushnikov@chromium.org
TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons
are correctly aligned. crbug.com/671930
==========

[lushnikov, 2017-01-23 05:44:28]

thank you for the patch! Works great
lgtm

[lushnikov, 2017-01-23 06:45:53]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-01-23 06:46:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 08:29:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485153953142220, "parent_rev":
"aef74347569707cc1dc80c66057e1228964b2d98", "commit_rev":
"4d2364eb32a5b242790324536efccd843cb81aa8"}

[commit-bot: I haz the power, 2017-01-23 08:29:49]

Description was changed from

==========
DevTools: Correct Source Panel Show/Hide Toolbar buttons

Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is
seen in devtools.

Flipped mask positions and removed—now unnecessary—rotation transforms around
show/hide panel icon containers.

BUG=671930
R=lushnikov@chromium.org
TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons
are correctly aligned. crbug.com/671930
==========

to

==========
DevTools: Correct Source Panel Show/Hide Toolbar buttons

Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is
seen in devtools.

Flipped mask positions and removed—now unnecessary—rotation transforms around
show/hide panel icon containers.

BUG=671930
R=lushnikov@chromium.org
TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons
are correctly aligned. crbug.com/671930

Review-Url: https://codereview.chromium.org/2600493002
Cr-Commit-Position: refs/heads/master@{#445339}
Committed:
https://chromium.googlesource.com/chromium/src/+/4d2364eb32a5b242790324536efc...
==========

[commit-bot: I haz the power, 2017-01-23 08:29:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d2364eb32a5b242790324536efc...

[lushnikov, 2017-01-25 07:17:34]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2655793003/ by lushnikov@chromium.org.

The reason for reverting is: It turned out the icons are actually wrong.
Compare:
- Without this patch (correct): http://imgur.com/a/eFCnz
- With this patch (incorrect): http://imgur.com/a/gJ24q
.