Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2655743002: Fix ScrollingCoordinator-related crash with page popups (Closed)

Created:
3 years, 11 months ago by kenrb
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix ScrollingCoordinator-related crash with page popups Rev 444497 introduced a crash that can happen when popups are opened, because in some cases they access the wrong compositor animation host and timeline. This fixes the issue by ensure they always use those resources on the top frame. BUG=683282 Review-Url: https://codereview.chromium.org/2647963002 Cr-Commit-Position: refs/heads/master@{#445192} (cherry picked from commit f15f669d84991252dd186c7093b885d7e909fad3) Review-Url: https://codereview.chromium.org/2655743002 . Cr-Commit-Position: refs/branch-heads/2987@{#63} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/37f84209a3c632b8cd696c50eca923d533f0e1a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 2 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kenrb
3 years, 11 months ago (2017-01-24 18:30:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37f84209a3c632b8cd696c50eca923d533f0e1a8.

Powered by Google App Engine
This is Rietveld 408576698