Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2655743002: Fix ScrollingCoordinator-related crash with page popups (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index ef30de3ab41f025199562a739f7fde2de55bd984..4672d5e89fa4ce88450d28c15cbe10f3f0673cb5 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -395,12 +395,7 @@ void WebPagePopupImpl::setIsAcceleratedCompositingActive(bool enter) {
m_isAcceleratedCompositingActive = true;
m_animationHost = WTF::makeUnique<CompositorAnimationHost>(
m_layerTreeView->compositorAnimationHost());
- m_page->layerTreeViewInitialized(*m_layerTreeView,
- m_popupClient->ownerElement()
- .document()
- .frame()
- ->localFrameRoot()
- ->view());
+ m_page->layerTreeViewInitialized(*m_layerTreeView, nullptr);
} else {
m_isAcceleratedCompositingActive = false;
m_animationHost = nullptr;
@@ -417,14 +412,8 @@ void WebPagePopupImpl::beginFrame(double lastFrameTimeMonotonic) {
}
void WebPagePopupImpl::willCloseLayerTreeView() {
- if (m_page && m_layerTreeView) {
- m_page->willCloseLayerTreeView(*m_layerTreeView,
- m_popupClient->ownerElement()
- .document()
- .frame()
- ->localFrameRoot()
- ->view());
- }
+ if (m_page && m_layerTreeView)
+ m_page->willCloseLayerTreeView(*m_layerTreeView, nullptr);
setIsAcceleratedCompositingActive(false);
m_layerTreeView = nullptr;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698