ABANDONED CL: Stop considering parameter count for methods blocked via --method-blocklist.

ABANDONED CL: Replaced by https://codereview.chromium.org/2781483004.

-------------

Stop considering parameter count for methods blocked via --method-blocklist.

BUG=673039

[Łukasz Anforowicz, 2017-02-06 23:19:45]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-02-06 23:19:45]

Daniel, can you PTAL?

Notes:
- With this CL, I can build clang after the rename.
- I guess this CL is admitting a defeat wrt accurate scraping of IDL files and
will result in skipping of renaming in some unnecessary cases.  OTOH, we've
always said that the tool won't handle 100% of cases and a manual intervention
will be needed to finish/polish renaming in a small number of cases.

IMO, this CL is an okay thing to land.  WDYT?

[dcheng, 2017-02-07 00:15:45]

How big a difference does this make for rename feasibility?

[Łukasz Anforowicz, 2017-02-07 17:43:08]

On 2017/02/07 00:15:45, dcheng wrote:
> How big a difference does this make for rename feasibility?

After a rename that pays attention to parameter count when skipping methods, I
get the following compile errors:

# Unique error messages:
$ cat ~/scratch/ninja.err | grep error: | grep -v 'undefined reference' | sed -e
's/^.*error: //g' | sort | uniq -c | sort -n
      1 no matching member function for call to 'compressedTexImage2D'
      1 no matching member function for call to 'compressedTexSubImage2D'
      1 no member named 'additionalData' in 'blink::PasswordCredential'; did you
mean 'AdditionalData'?
      1 no member named 'appRequest' in 'blink::PaymentRequestEvent'; did you
mean 'AppRequest'?
      1 no member named 'create' in 'blink::IDBObserverCallback'; did you mean
'Create'?
      1 no member named 'getConfiguration' in 'blink::MediaKeySystemAccess'; did
you mean 'GetConfiguration'?
      1 no member named 'getConstraints' in 'blink::MediaStreamTrack'; did you
mean 'GetConstraints'?
      1 no member named 'getContextAttributes' in
'blink::CanvasRenderingContext2D'; did you mean 'GetContextAttributes'?
      1 no member named 'getContextAttributes' in
'blink::WebGL2RenderingContext'
      1 no member named 'getContextAttributes' in
'blink::WebGLRenderingContext'; did you mean 'GetContextAttributes'?
      1 no member named 'getContext' in 'blink::HTMLCanvasElementModule'; did
you mean 'GetContext'?
      1 no member named 'getContext' in 'blink::OffscreenCanvasModules'; did you
mean 'GetContext'?
      1 no member named 'getDerivedDerived' in 'blink::DictionaryTest'
      1 no member named 'getDerived' in 'blink::DictionaryTest'
      1 no member named 'get' in 'blink::DictionaryTest'
      1 no member named 'getOutputTimestamp' in 'blink::AudioContext'; did you
mean 'GetOutputTimestamp'?
      1 no member named 'getSettings' in 'blink::MediaStreamTrack'; did you mean
'GetSettings'?
      1 no member named 'getSupportedConstraints' in 'blink::MediaDevices'; did
you mean 'GetSupportedConstraints'?
      1 no member named 'getSupportedExtensions' in
'blink::WebGL2RenderingContext'
      1 no member named 'getSupportedExtensions' in
'blink::WebGLRenderingContext'; did you mean 'GetSupportedExtensions'?
      1 no member named 'getUniformIndices' in 'blink::WebGL2RenderingContext';
did you mean 'GetUniformIndices'?
      1 no member named 'timestamp' in 'blink::Sensor'; did you mean
'Timestamp'?
      1 too few arguments to function call, single argument 'is_null' was not
specified
      2 too few arguments to function call, expected 2, have 1
      2 too few arguments to function call, expected 5, have 3
      5 no matching member function for call to 'texImage2D'
      5 no matching member function for call to 'texSubImage2D'
    228 too few arguments to function call, expected 3, have 2

# Unique source files:
$ cat ~/scratch/ninja.err | grep error: | grep -v 'undefined reference' | sed -e
's/:.*$//g' | sort | uniq -c | sort -n | wc -l
71

[Łukasz Anforowicz, 2017-02-07 18:30:29]

On 2017/02/07 17:43:08, Łukasz Anforowicz wrote:
> On 2017/02/07 00:15:45, dcheng wrote:
> > How big a difference does this make for rename feasibility?
> 
> After a rename that pays attention to parameter count when skipping methods, I
> get the following compile errors:
> 
> # Unique error messages:
> $ cat ~/scratch/ninja.err | grep error: | grep -v 'undefined reference' | sed
-e
> 's/^.*error: //g' | sort | uniq -c | sort -n
>       1 no matching member function for call to 'compressedTexImage2D'
>       1 no matching member function for call to 'compressedTexSubImage2D'
>       1 no member named 'additionalData' in 'blink::PasswordCredential'; did
you
> mean 'AdditionalData'?
>       1 no member named 'appRequest' in 'blink::PaymentRequestEvent'; did you
> mean 'AppRequest'?
>       1 no member named 'create' in 'blink::IDBObserverCallback'; did you mean
> 'Create'?
>       1 no member named 'getConfiguration' in 'blink::MediaKeySystemAccess';
did
> you mean 'GetConfiguration'?
>       1 no member named 'getConstraints' in 'blink::MediaStreamTrack'; did you
> mean 'GetConstraints'?
>       1 no member named 'getContextAttributes' in
> 'blink::CanvasRenderingContext2D'; did you mean 'GetContextAttributes'?
>       1 no member named 'getContextAttributes' in
> 'blink::WebGL2RenderingContext'
>       1 no member named 'getContextAttributes' in
> 'blink::WebGLRenderingContext'; did you mean 'GetContextAttributes'?
>       1 no member named 'getContext' in 'blink::HTMLCanvasElementModule'; did
> you mean 'GetContext'?
>       1 no member named 'getContext' in 'blink::OffscreenCanvasModules'; did
you
> mean 'GetContext'?
>       1 no member named 'getDerivedDerived' in 'blink::DictionaryTest'
>       1 no member named 'getDerived' in 'blink::DictionaryTest'
>       1 no member named 'get' in 'blink::DictionaryTest'
>       1 no member named 'getOutputTimestamp' in 'blink::AudioContext'; did you
> mean 'GetOutputTimestamp'?
>       1 no member named 'getSettings' in 'blink::MediaStreamTrack'; did you
mean
> 'GetSettings'?
>       1 no member named 'getSupportedConstraints' in 'blink::MediaDevices';
did
> you mean 'GetSupportedConstraints'?
>       1 no member named 'getSupportedExtensions' in
> 'blink::WebGL2RenderingContext'
>       1 no member named 'getSupportedExtensions' in
> 'blink::WebGLRenderingContext'; did you mean 'GetSupportedExtensions'?
>       1 no member named 'getUniformIndices' in
'blink::WebGL2RenderingContext';
> did you mean 'GetUniformIndices'?
>       1 no member named 'timestamp' in 'blink::Sensor'; did you mean
> 'Timestamp'?
>       1 too few arguments to function call, single argument 'is_null' was not
> specified
>       2 too few arguments to function call, expected 2, have 1
>       2 too few arguments to function call, expected 5, have 3
>       5 no matching member function for call to 'texImage2D'
>       5 no matching member function for call to 'texSubImage2D'
>     228 too few arguments to function call, expected 3, have 2
> 
> # Unique source files:
> $ cat ~/scratch/ninja.err | grep error: | grep -v 'undefined reference' | sed
-e
> 's/:.*$//g' | sort | uniq -c | sort -n | wc -l
> 71

Oh, and I think (guess, really) that most cases above are caused by not
recognizing dictionaries/unions as things requiring an out parameter (as opposed
to a return value).  Some discussion on that happened in
https://codereview.chromium.org/2624413002/#msg7

[dcheng, 2017-03-22 00:50:21]

LGTM

(Per the discussion with nasko, we're just going to move ahead with the simple
approach)

[dcheng, 2017-03-22 00:50:25]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2017-03-22 00:50:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 00:55:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 00:55:28]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Łukasz Anforowicz, 2017-03-29 22:43:52]

Description was changed from

==========
Stop considering parameter count for methods blocked via --method-blocklist.

BUG=673039
==========

to

==========
ABANDONED CL: Replaced by https://codereview.chromium.org/2781483004.

-------------

Stop considering parameter count for methods blocked via --method-blocklist.

BUG=673039
==========