Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 2655543002: ABANDONED CL: Stop considering parameter count for methods blocked via --method-blocklist. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gen/thing.h" 5 #include "gen/thing.h"
6 6
7 namespace v8 { 7 namespace v8 {
8 8
9 class InterfaceOutsideOfBlink { 9 class InterfaceOutsideOfBlink {
10 public: 10 public:
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 class InternalClass { 302 class InternalClass {
303 public: 303 public:
304 static void method(); 304 static void method();
305 }; 305 };
306 306
307 } // namespace internal 307 } // namespace internal
308 308
309 // Tests for --method-blocklist cmdline parameter. 309 // Tests for --method-blocklist cmdline parameter.
310 class IdlTestClass { 310 class IdlTestClass {
311 public: 311 public:
312 static int idlTestMethodNoParams(char x) { return 123; } 312 static int notBlocklistedMethod() { return 123; }
313 static int idlTestMethodOneParam(char x) { return 123; } 313 int notBlocklistedMethod(int x) { return 123; }
314 314
315 int idlTestMethodNoParams() { return 123; } 315 static int idlStaticMethod() { return 123; }
316 int idlTestMethodNoParams(int x) { return 123; } 316 int idlInstanceMethod() { return 123; }
317
318 int idlTestMethodOneParam() { return 123; }
319 int idlTestMethodOneParam(int x) { return 123; }
320
321 int idlTestMethodTwoOrThreeParams() { return 123; }
322 int idlTestMethodTwoOrThreeParams(int x, int y) { return 123; }
323 int idlTestMethodTwoOrThreeParams(int x, int y, int z) { return 123; }
324
325 int idlOptionalArgsPass(int x = 0) { return x; }
326 int idlOptionalArgsStillTooMany(int x, int y = 0) { return x + y; }
327 int idlOptionalArgsTooLittle(int x = 0) { return x; }
328 317
329 template <typename T> 318 template <typename T>
330 int idlTemplateMethod(T x) { 319 int idlTemplateMethod(T x) {
331 return 123; 320 return 123;
332 } 321 }
333
334 int path() { return 123; }
335 int path(int x) { return 123; }
336 }; 322 };
337 323
338 template <typename T> 324 template <typename T>
339 class IdlTemplateClass { 325 class IdlTemplateClass {
340 public: 326 public:
341 int idlTestMethod(T x) { return 123; } 327 int idlInstanceMethod(T x) { return 123; }
342 }; 328 };
343 329
344 } // namespace blink 330 } // namespace blink
345 331
346 // https://crbug.com/640688 - need to rewrite method name below. 332 // https://crbug.com/640688 - need to rewrite method name below.
347 void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {} 333 void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {}
348 void blink::internal::InternalClass::method() {} 334 void blink::internal::InternalClass::method() {}
OLDNEW
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698