Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2655333006: media: Work around an Android bug in the video size browsertests (Closed)

Created:
3 years, 10 months ago by watk
Modified:
3 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Add an Android bug workaround to the video size media browsertests The video size tests previously only waited for loadedmetadata before completing and killing the browser processes. This resulted in some unfortunate timing where the GPU process was being killed shortly after a MediaCodec was allocated, triggering a framework bug that put the device into a broken state until it's rebooted. Since we don't have any way to fix the underlying issue this CL changes the test so it no longer triggers the bug. The test now waits for the decoder to initialize by waiting for loadeddata. BUG=682387 Review-Url: https://codereview.chromium.org/2655333006 Cr-Commit-Position: refs/heads/master@{#446906} Committed: https://chromium.googlesource.com/chromium/src/+/54db2003b44f32d6618e70682b84fb8d13fd4e15

Patch Set 1 #

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/browser/media/media_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/test/data/player.html View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
watk
since you're still here :)
3 years, 10 months ago (2017-01-28 01:54:23 UTC) #3
DaleCurtis
lgtm
3 years, 10 months ago (2017-01-28 01:59:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655333006/20001
3 years, 10 months ago (2017-01-28 02:02:24 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 04:13:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/54db2003b44f32d6618e70682b84...

Powered by Google App Engine
This is Rietveld 408576698