Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: media/test/data/player.html

Issue 2655333006: media: Work around an Android bug in the video size browsertests (Closed)
Patch Set: fix comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/media_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/test/data/player.html
diff --git a/media/test/data/player.html b/media/test/data/player.html
index a1f46392928fc983cacc00579ae129b0ae7b3f35..7577d8619f9cc173116311f28cb52000353615ba 100644
--- a/media/test/data/player.html
+++ b/media/test/data/player.html
@@ -84,7 +84,12 @@ function RunTest() {
player.controls = true;
document.getElementById('player_container').appendChild(player);
- player.addEventListener('loadedmetadata', function(e) {
+ // We use loadeddata instead of loadedmetadata to ensure the decoder has
+ // completed initialization, even though we don't need to decode anything to
+ // get the size metadata. This is an unfortunate workaround for an Android
+ // framework bug (http://crbug.com/682387) where we have to avoid killing
+ // the GPU process while the decoder is initializing.
+ player.addEventListener('loadeddata', function(e) {
document.title = '' + player.videoWidth + ' ' + player.videoHeight;
});
« no previous file with comments | « content/browser/media/media_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698