Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2655223003: Revert of [tests] Make assertOptimized()/assertUnoptimized() great again. (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [tests] Make assertOptimized()/assertUnoptimized() great again. (patchset #6 id:130042 of https://codereview.chromium.org/2654733004/ ) Reason for revert: Mac gc stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/11195 There's also this flake, but maybe unrelated: https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/15422 Original issue's description: > [tests] Make assertOptimized()/assertUnoptimized() great again. > > The mentioned asserts did not work properly with interpreted and turbofanned functions. > > To fix this issue %GetOptimizationStatus() now returns a set of flags instead of a single value. > > This CL also adds more helper functions to mjsunit, like isNeverOptimize(), isAlwaysOptimize(), > isOptimized(fun), etc. > > BUG=v8:5890 > > Review-Url: https://codereview.chromium.org/2654733004 > Cr-Commit-Position: refs/heads/master@{#42703} > Committed: https://chromium.googlesource.com/v8/v8/+/d1ddec785725a184fe6d01bd0813262e3ba24966 TBR=mstarzinger@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5890 Review-Url: https://codereview.chromium.org/2655223003 Cr-Commit-Position: refs/heads/master@{#42704} Committed: https://chromium.googlesource.com/v8/v8/+/d2d99e084ad7878cd32746a40f657e51ca697a3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -339 lines) Patch
M src/compiler.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/d8.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/runtime/runtime-test.cc View 2 chunks +17 lines, -18 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 3 chunks +1 line, -6 lines 0 comments Download
M test/debugger/debug/regress/regress-prepare-break-while-recompile.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/debugger/debugger.status View 1 chunk +7 lines, -0 lines 0 comments Download
M test/mjsunit/array-bounds-check-removal.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 6 chunks +26 lines, -23 lines 0 comments Download
M test/mjsunit/array-literal-transitions.js View 2 chunks +5 lines, -7 lines 0 comments Download
M test/mjsunit/array-push5.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/array-store-and-grow.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/assert-opt-and-deopt.js View 4 chunks +28 lines, -9 lines 0 comments Download
M test/mjsunit/compiler/concurrent-invalidate-transition-map.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/compiler/concurrent-proto-change.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/compiler/deopt-string-outofbounds.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/compiler/manual-concurrent-recompile.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/concurrent-initial-prototype-change.js View 2 chunks +1 line, -3 lines 0 comments Download
M test/mjsunit/deopt-with-fp-regs.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/ensure-growing-store-learns.js View 2 chunks +25 lines, -26 lines 0 comments Download
M test/mjsunit/es6/array-iterator-turbo.js View 4 chunks +25 lines, -22 lines 0 comments Download
M test/mjsunit/es6/block-let-crankshaft.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/block-let-crankshaft-sloppy.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/block-scoping.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/block-scoping-sloppy.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/field-type-tracking.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/do-expressions.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/keyed-load-hole-to-undefined.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/keyed-load-with-symbol-key.js View 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/mjsunit.js View 2 chunks +2 lines, -94 lines 0 comments Download
M test/mjsunit/never-optimize.js View 1 chunk +28 lines, -24 lines 0 comments Download
M test/mjsunit/regress/regress-2618.js View 3 chunks +3 lines, -5 lines 0 comments Download
M test/mjsunit/regress/regress-3709.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/regress/regress-385565.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/regress/regress-4121.js View 2 chunks +8 lines, -4 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-500497.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-594183.js View 1 chunk +1 line, -5 lines 0 comments Download
M test/mjsunit/regress/regress-embedded-cons-string.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-v8-5697.js View 2 chunks +0 lines, -2 lines 0 comments Download
M test/mjsunit/shared-function-tier-up-default.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/shared-function-tier-up-ignition.js View 1 chunk +5 lines, -6 lines 0 comments Download
M test/mjsunit/shared-function-tier-up-turbo.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [tests] Make assertOptimized()/assertUnoptimized() great again.
3 years, 11 months ago (2017-01-26 15:04:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655223003/1
3 years, 11 months ago (2017-01-26 15:04:34 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 15:04:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d2d99e084ad7878cd32746a40f657e51ca6...

Powered by Google App Engine
This is Rietveld 408576698