[tests] Make assertOptimized()/assertUnoptimized() great again.

[tests] Make assertOptimized()/assertUnoptimized() great again.

The mentioned asserts did not work properly with interpreted and turbofanned functions.

To fix this issue %GetOptimizationStatus() now returns a set of flags instead of a single value.

This CL also adds more helper functions to mjsunit, like isNeverOptimize(), isAlwaysOptimize(),
isOptimized(fun), etc.

BUG=v8:5890
Review-Url: https://codereview.chromium.org/2654733004
Cr-Original-Commit-Position: refs/heads/master@{#42703}
Committed: https://chromium.googlesource.com/v8/v8/+/d1ddec785725a184fe6d01bd0813262e3ba24966
Review-Url: https://codereview.chromium.org/2654733004
Cr-Commit-Position: refs/heads/master@{#42731}
Committed: https://chromium.googlesource.com/v8/v8/+/4a5446fb2b50ef4756117135a6f18fb0c7309852

[Igor Sheludko, 2017-01-25 11:05:22]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2017-01-25 11:26:00]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2017-01-25 11:31:11]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2017-01-25 11:38:41]

ishell@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Igor Sheludko, 2017-01-25 11:38:42]

PTAL

https://codereview.chromium.org/2654733004/diff/60001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-crbug-594183.js (right):

https://codereview.chromium.org/2654733004/diff/60001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-crbug-594183.js:5: // Flags: --allow-natives-syntax
--no-turbo
TF is not sophisticated as CS and it does not use IcCheckType value yet,
therefore it does not deoptimize in the end. Just skip this test for TF.

https://codereview.chromium.org/2654733004/diff/60001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-v8-5697.js (right):

https://codereview.chromium.org/2654733004/diff/60001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-v8-5697.js:12: % OptimizeFunctionOnNextCall(load);
Optimization of load() did not kick in with --ignition-staging.

[Igor Sheludko, 2017-01-25 11:40:18]

Description was changed from

==========
[tests] Make assertOptimized/assertUnoptimized great (working) again.

The mentioned asserts did not work properly with interpreted and turbofanned
code.

This CL makes %GetOptimizationStatus() return a set of flags instead of a single
value.

BUG=
==========

to

==========
[tests] Make assertOptimized/assertUnoptimized great (working) again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

This CL makes %GetOptimizationStatus() return a set of flags instead of a single
value.

BUG=
==========

[Igor Sheludko, 2017-01-25 11:40:25]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 11:40:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-01-25 11:57:26]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 11:57:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 12:11:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 12:11:09]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Igor Sheludko, 2017-01-25 18:11:12]

Patchset #3 (id:100001) has been deleted

[Igor Sheludko, 2017-01-25 18:13:32]

Patchset #3 (id:120001) has been deleted

[Igor Sheludko, 2017-01-25 18:13:46]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 18:13:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-01-25 18:17:10]

Description was changed from

==========
[tests] Make assertOptimized/assertUnoptimized great (working) again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

This CL makes %GetOptimizationStatus() return a set of flags instead of a single
value.

BUG=
==========

to

==========
[tests] Make assertOptimized/assertUnoptimized great again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

To fix this issue %GetOptimizationStatus() now returns a set of flags instead of
a single value.

This CL also adds more helper functions to mjsunit, like isNeverOptimize(),
isAlwaysOptimize(),
isOptimized(fun), etc.

BUG=
==========

[Igor Sheludko, 2017-01-25 18:21:31]

Description was changed from

==========
[tests] Make assertOptimized/assertUnoptimized great again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

To fix this issue %GetOptimizationStatus() now returns a set of flags instead of
a single value.

This CL also adds more helper functions to mjsunit, like isNeverOptimize(),
isAlwaysOptimize(),
isOptimized(fun), etc.

BUG=
==========

to

==========
[tests] Make assertOptimized()/assertUnoptimized() great again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

To fix this issue %GetOptimizationStatus() now returns a set of flags instead of
a single value.

This CL also adds more helper functions to mjsunit, like isNeverOptimize(),
isAlwaysOptimize(),
isOptimized(fun), etc.

BUG=
==========

[commit-bot: I haz the power, 2017-01-25 18:34:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 18:34:46]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/21542)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/21630)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[Igor Sheludko, 2017-01-25 19:50:15]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 19:50:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 20:10:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 20:10:33]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/19992)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Igor Sheludko, 2017-01-25 22:49:42]

Description was changed from

==========
[tests] Make assertOptimized()/assertUnoptimized() great again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

To fix this issue %GetOptimizationStatus() now returns a set of flags instead of
a single value.

This CL also adds more helper functions to mjsunit, like isNeverOptimize(),
isAlwaysOptimize(),
isOptimized(fun), etc.

BUG=
==========

to

==========
[tests] Make assertOptimized()/assertUnoptimized() great again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

To fix this issue %GetOptimizationStatus() now returns a set of flags instead of
a single value.

This CL also adds more helper functions to mjsunit, like isNeverOptimize(),
isAlwaysOptimize(),
isOptimized(fun), etc.

BUG=v8:5890
==========

[Igor Sheludko, 2017-01-26 11:52:50]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 11:52:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2017-01-26 12:24:52]

Cool stuff, I like it, just a bunch smallish comments.

https://codereview.chromium.org/2654733004/diff/60001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-crbug-594183.js (right):

https://codereview.chromium.org/2654733004/diff/60001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-crbug-594183.js:5: // Flags: --allow-natives-syntax
--no-turbo
On 2017/01/25 11:38:42, Igor Sheludko wrote:
> TF is not sophisticated as CS and it does not use IcCheckType value yet,
> therefore it does not deoptimize in the end. Just skip this test for TF.

Acknowledged.

https://codereview.chromium.org/2654733004/diff/60001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-v8-5697.js (right):

https://codereview.chromium.org/2654733004/diff/60001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-v8-5697.js:12: % OptimizeFunctionOnNextCall(load);
On 2017/01/25 11:38:42, Igor Sheludko wrote:
> Optimization of load() did not kick in with --ignition-staging.

Is the loop still needed on this case?

https://codereview.chromium.org/2654733004/diff/60001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-v8-5697.js:24: % OptimizeFunctionOnNextCall(store);
Likewise.

https://codereview.chromium.org/2654733004/diff/180001/src/runtime/runtime.h
File src/runtime/runtime.h (right):

https://codereview.chromium.org/2654733004/diff/180001/src/runtime/runtime.h#...
src/runtime/runtime.h:1157: // A set of bits returned by
Runtime_GetOpmtimizationStatus.
nit: s/Opmtimization/Optimization/

https://codereview.chromium.org/2654733004/diff/180001/src/runtime/runtime.h#...
src/runtime/runtime.h:1168: kIsOptmimizedFunctionMask = kIsFunction |
kOptimized,
nit: s/Optmimized/Optimized/, also I would vote for dropping this constant and
use the two underlying flags directly in Regress256330.

https://codereview.chromium.org/2654733004/diff/180001/test/mjsunit/assert-op...
File test/mjsunit/assert-opt-and-deopt.js (right):

https://codereview.chromium.org/2654733004/diff/180001/test/mjsunit/assert-op...
test/mjsunit/assert-opt-and-deopt.js:52: kIsFunction: 1 << 0,
suggestion: Could we map these to the existing constants in the mjsunit.js file
to have one less place that needs to be kept in sync? I am thinking along the
lines of ...

OptTracker.OptimizationState = {
  kIsFunction: V8OptimizationStatus.kIsFunction,
  ...
}

Or alternatively we could use the constant directly in the below test. WDYT?

https://codereview.chromium.org/2654733004/diff/180001/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (right):

https://codereview.chromium.org/2654733004/diff/180001/test/mjsunit/mjsunit.j...
test/mjsunit/mjsunit.js:537: (opt_status & V8OptimizationStatus.kInterpreted)
=== 0;
Not sure this is entirely correct. Will this report a function that has never
been compiled (i.e. has the LazyCompile stub) be reported as {isBaseline}? If we
want this predicate, then we should probably have a dedicate bit like
{kBaselined}.

https://codereview.chromium.org/2654733004/diff/180001/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-v8-5697.js (right):

https://codereview.chromium.org/2654733004/diff/180001/test/mjsunit/regress/r...
test/mjsunit/regress/regress-v8-5697.js:12: % OptimizeFunctionOnNextCall(load);
nit: Can we drop the whitespace after the "%" sign?

https://codereview.chromium.org/2654733004/diff/180001/test/mjsunit/regress/r...
test/mjsunit/regress/regress-v8-5697.js:24: % OptimizeFunctionOnNextCall(store);
nit: Can we drop the whitespace after the "%" sign?

[commit-bot: I haz the power, 2017-01-26 12:30:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 12:30:08]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-01-26 13:00:51]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 13:01:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2017-01-26 13:05:17]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2017-01-26 13:05:18]

https://codereview.chromium.org/2654733004/diff/130042/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (right):

https://codereview.chromium.org/2654733004/diff/130042/test/mjsunit/mjsunit.j...
test/mjsunit/mjsunit.js:123: // These bits must be in sync with bits defined in
Runtime_GetOptimizationStatus
Please update the fake mjsunit.js used by internal fuzzers before landing this.

[commit-bot: I haz the power, 2017-01-26 13:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 13:35:54]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-01-26 14:12:34]

https://codereview.chromium.org/2654733004/diff/60001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-v8-5697.js (right):

https://codereview.chromium.org/2654733004/diff/60001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-v8-5697.js:12: % OptimizeFunctionOnNextCall(load);
On 2017/01/26 12:24:52, Michael Starzinger wrote:
> On 2017/01/25 11:38:42, Igor Sheludko wrote:
> > Optimization of load() did not kick in with --ignition-staging.
> 
> Is the loop still needed on this case?

Yes. The test checks that we don't have a deopt loop here.

https://codereview.chromium.org/2654733004/diff/180001/src/runtime/runtime.h
File src/runtime/runtime.h (right):

https://codereview.chromium.org/2654733004/diff/180001/src/runtime/runtime.h#...
src/runtime/runtime.h:1157: // A set of bits returned by
Runtime_GetOpmtimizationStatus.
On 2017/01/26 12:24:52, Michael Starzinger wrote:
> nit: s/Opmtimization/Optimization/

Done.

https://codereview.chromium.org/2654733004/diff/180001/src/runtime/runtime.h#...
src/runtime/runtime.h:1168: kIsOptmimizedFunctionMask = kIsFunction |
kOptimized,
On 2017/01/26 12:24:52, Michael Starzinger wrote:
> nit: s/Optmimized/Optimized/, also I would vote for dropping this constant and
> use the two underlying flags directly in Regress256330.

Removed.

https://codereview.chromium.org/2654733004/diff/180001/test/mjsunit/assert-op...
File test/mjsunit/assert-opt-and-deopt.js (right):

https://codereview.chromium.org/2654733004/diff/180001/test/mjsunit/assert-op...
test/mjsunit/assert-opt-and-deopt.js:52: kIsFunction: 1 << 0,
On 2017/01/26 12:24:52, Michael Starzinger wrote:
> suggestion: Could we map these to the existing constants in the mjsunit.js
file
> to have one less place that needs to be kept in sync? I am thinking along the
> lines of ...
> 
> OptTracker.OptimizationState = {
>   kIsFunction: V8OptimizationStatus.kIsFunction,
>   ...
> }
> 
> Or alternatively we could use the constant directly in the below test. WDYT?

Given that this file already uses stuff from mjsunit.js it's really better to
just use V8OptimizationStatus here directly.

https://codereview.chromium.org/2654733004/diff/180001/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-v8-5697.js (right):

https://codereview.chromium.org/2654733004/diff/180001/test/mjsunit/regress/r...
test/mjsunit/regress/regress-v8-5697.js:12: % OptimizeFunctionOnNextCall(load);
On 2017/01/26 12:24:52, Michael Starzinger wrote:
> nit: Can we drop the whitespace after the "%" sign?

Done.

https://codereview.chromium.org/2654733004/diff/180001/test/mjsunit/regress/r...
test/mjsunit/regress/regress-v8-5697.js:24: % OptimizeFunctionOnNextCall(store);
On 2017/01/26 12:24:52, Michael Starzinger wrote:
> nit: Can we drop the whitespace after the "%" sign?

Done.

[Michael Starzinger, 2017-01-26 14:25:55]

LGTM from my end. Thanks!

[Igor Sheludko, 2017-01-26 14:33:20]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2017-01-26 14:33:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 14:35:30]

CQ is committing da patch.

Bot data: {"patchset_id": 130042, "attempt_start_ts": 1485441200818840,
"parent_rev": "06b46ab1df37b27285b8a88413d1060a6b6633f8", "commit_rev":
"d1ddec785725a184fe6d01bd0813262e3ba24966"}

[commit-bot: I haz the power, 2017-01-26 14:35:34]

Description was changed from

==========
[tests] Make assertOptimized()/assertUnoptimized() great again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

To fix this issue %GetOptimizationStatus() now returns a set of flags instead of
a single value.

This CL also adds more helper functions to mjsunit, like isNeverOptimize(),
isAlwaysOptimize(),
isOptimized(fun), etc.

BUG=v8:5890
==========

to

==========
[tests] Make assertOptimized()/assertUnoptimized() great again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

To fix this issue %GetOptimizationStatus() now returns a set of flags instead of
a single value.

This CL also adds more helper functions to mjsunit, like isNeverOptimize(),
isAlwaysOptimize(),
isOptimized(fun), etc.

BUG=v8:5890

Review-Url: https://codereview.chromium.org/2654733004
Cr-Commit-Position: refs/heads/master@{#42703}
Committed:
https://chromium.googlesource.com/v8/v8/+/d1ddec785725a184fe6d01bd0813262e3ba...
==========

[commit-bot: I haz the power, 2017-01-26 14:35:35]

Committed patchset #6 (id:130042) as
https://chromium.googlesource.com/v8/v8/+/d1ddec785725a184fe6d01bd0813262e3ba...

[Michael Achenbach, 2017-01-26 15:04:25]

A revert of this CL (patchset #6 id:130042) has been created in
https://codereview.chromium.org/2655223003/ by machenbach@chromium.org.

The reason for reverting is: Mac gc stress failures:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds...

There's also this flake, but maybe unrelated:
https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/15422.

[Michael Achenbach, 2017-01-26 15:17:22]

On 2017/01/26 15:04:25, Michael Achenbach wrote:
> A revert of this CL (patchset #6 id:130042) has been created in
> https://codereview.chromium.org/2655223003/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: Mac gc stress failures:
>
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds...
> 
> There's also this flake, but maybe unrelated:
> https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/15422.

Note also the deopt fuzzer failures:
https://build.chromium.org/p/client.v8/builders/V8%20Deopt%20Fuzzer/builds/16480

[Michael Achenbach, 2017-01-26 15:33:03]

Ignore the shell test runner flake. That one is still in after the revert:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/1...

[Igor Sheludko, 2017-01-26 16:46:26]

Description was changed from

==========
[tests] Make assertOptimized()/assertUnoptimized() great again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

To fix this issue %GetOptimizationStatus() now returns a set of flags instead of
a single value.

This CL also adds more helper functions to mjsunit, like isNeverOptimize(),
isAlwaysOptimize(),
isOptimized(fun), etc.

BUG=v8:5890

Review-Url: https://codereview.chromium.org/2654733004
Cr-Commit-Position: refs/heads/master@{#42703}
Committed:
https://chromium.googlesource.com/v8/v8/+/d1ddec785725a184fe6d01bd0813262e3ba...
==========

to

==========
[tests] Make assertOptimized()/assertUnoptimized() great again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

To fix this issue %GetOptimizationStatus() now returns a set of flags instead of
a single value.

This CL also adds more helper functions to mjsunit, like isNeverOptimize(),
isAlwaysOptimize(),
isOptimized(fun), etc.

BUG=v8:5890

Review-Url: https://codereview.chromium.org/2654733004
Cr-Commit-Position: refs/heads/master@{#42703}
Committed:
https://chromium.googlesource.com/v8/v8/+/d1ddec785725a184fe6d01bd0813262e3ba...
==========

[Igor Sheludko, 2017-01-26 16:51:40]

I'm sorry, I had to reshuffle the code a bit. This CL is mostly the same except
the assertOptimized() which has to handle kMaybeDeopted case.

https://codereview.chromium.org/2654733004/diff/210001/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (right):

https://codereview.chromium.org/2654733004/diff/210001/test/mjsunit/mjsunit.j...
test/mjsunit/mjsunit.js:514: if ((opt_status &
V8OptimizationStatus.kMaybeDeopted) !== 0) {
This case is new.

[Igor Sheludko, 2017-01-26 16:52:06]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 16:52:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 17:29:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 17:29:13]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-01-27 09:28:51]

Patchset #7 (id:210001) has been deleted

[Igor Sheludko, 2017-01-27 09:30:54]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 09:31:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-01-27 09:33:06]

https://codereview.chromium.org/2654733004/diff/230001/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (right):

https://codereview.chromium.org/2654733004/diff/230001/test/mjsunit/mjsunit.j...
test/mjsunit/mjsunit.js:514: if ((opt_status &
V8OptimizationStatus.kMaybeDeopted) !== 0) {
This case is new.

[commit-bot: I haz the power, 2017-01-27 10:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 10:05:57]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2017-01-27 10:10:25]

Yep, patch set #7 still LGTM.

https://codereview.chromium.org/2654733004/diff/230001/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (right):

https://codereview.chromium.org/2654733004/diff/230001/test/mjsunit/mjsunit.j...
test/mjsunit/mjsunit.js:514: if ((opt_status &
V8OptimizationStatus.kMaybeDeopted) !== 0) {
On 2017/01/27 09:33:06, Igor Sheludko wrote:
> This case is new.

Acknowledged.

[Igor Sheludko, 2017-01-27 10:11:44]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2017-01-27 10:11:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 10:13:54]

CQ is committing da patch.

Bot data: {"patchset_id": 230001, "attempt_start_ts": 1485511904466270,
"parent_rev": "e29a2cd5296650efc29cfe9f0241628b9865ecb9", "commit_rev":
"4a5446fb2b50ef4756117135a6f18fb0c7309852"}

[commit-bot: I haz the power, 2017-01-27 10:13:59]

Description was changed from

==========
[tests] Make assertOptimized()/assertUnoptimized() great again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

To fix this issue %GetOptimizationStatus() now returns a set of flags instead of
a single value.

This CL also adds more helper functions to mjsunit, like isNeverOptimize(),
isAlwaysOptimize(),
isOptimized(fun), etc.

BUG=v8:5890

Review-Url: https://codereview.chromium.org/2654733004
Cr-Commit-Position: refs/heads/master@{#42703}
Committed:
https://chromium.googlesource.com/v8/v8/+/d1ddec785725a184fe6d01bd0813262e3ba...
==========

to

==========
[tests] Make assertOptimized()/assertUnoptimized() great again.

The mentioned asserts did not work properly with interpreted and turbofanned
functions.

To fix this issue %GetOptimizationStatus() now returns a set of flags instead of
a single value.

This CL also adds more helper functions to mjsunit, like isNeverOptimize(),
isAlwaysOptimize(),
isOptimized(fun), etc.

BUG=v8:5890

Review-Url: https://codereview.chromium.org/2654733004
Cr-Original-Commit-Position: refs/heads/master@{#42703}
Committed:
https://chromium.googlesource.com/v8/v8/+/d1ddec785725a184fe6d01bd0813262e3ba...
Review-Url: https://codereview.chromium.org/2654733004
Cr-Commit-Position: refs/heads/master@{#42731}
Committed:
https://chromium.googlesource.com/v8/v8/+/4a5446fb2b50ef4756117135a6f18fb0c73...
==========

[commit-bot: I haz the power, 2017-01-27 10:14:00]

Committed patchset #7 (id:230001) as
https://chromium.googlesource.com/v8/v8/+/4a5446fb2b50ef4756117135a6f18fb0c73...