Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2655093002: QUIC: add missing files to net/BUILD.gn (Closed)

Created:
3 years, 11 months ago by Buck
Modified:
3 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC: add missing files to net/BUILD.gn Followup to https://codereview.chromium.org/2593243003 Did some manual find/grepping to compare the state of the tree to BUILD.gn. Seems I missed two changes in the above: https://codereview.chromium.org/2651673004 https://codereview.chromium.org/2645103002 other files were apparently truly missing from net.gypi (or typos in one case). R=rch@chromium.org BUG= Review-Url: https://codereview.chromium.org/2655093002 Cr-Commit-Position: refs/heads/master@{#446196} Committed: https://chromium.googlesource.com/chromium/src/+/b07e16045b933d06587a8483731ffae24e21e6a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M net/BUILD.gn View 6 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Buck
3 years, 11 months ago (2017-01-25 19:58:14 UTC) #1
Ryan Hamilton
lgtm Awesome! It's to bad there's no tool to check this for us automatically as ...
3 years, 11 months ago (2017-01-25 20:07:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655093002/1
3 years, 11 months ago (2017-01-25 20:08:54 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/143793)
3 years, 11 months ago (2017-01-25 21:23:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655093002/1
3 years, 11 months ago (2017-01-26 01:16:25 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 01:39:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b07e16045b933d06587a8483731f...

Powered by Google App Engine
This is Rietveld 408576698