Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2645103002: Add quic_stack_trace. (Closed)

Created:
3 years, 11 months ago by Fan Yang
Modified:
3 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add quic_stack_trace. Merge internal change: 145081840. BUG= Review-Url: https://codereview.chromium.org/2645103002 Cr-Commit-Position: refs/heads/master@{#445390} Committed: https://chromium.googlesource.com/chromium/src/+/a1dcccc116e8728f5c00a5e0d69b34358ed9d565

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
M net/net.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
A net/quic/platform/api/quic_stack_trace.h View 1 chunk +18 lines, -0 lines 0 comments Download
A net/quic/platform/impl/quic_stack_trace_impl.h View 1 chunk +18 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 24 (17 generated)
Fan Yang
3 years, 11 months ago (2017-01-20 15:44:51 UTC) #5
Ryan Hamilton
lgtm
3 years, 11 months ago (2017-01-22 16:20:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645103002/1
3 years, 11 months ago (2017-01-23 15:40:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/353024)
3 years, 11 months ago (2017-01-23 15:41:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645103002/20001
3 years, 11 months ago (2017-01-23 15:46:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645103002/20001
3 years, 11 months ago (2017-01-23 16:53:18 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 16:59:01 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a1dcccc116e8728f5c00a5e0d69b...

Powered by Google App Engine
This is Rietveld 408576698