Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2654993007: Revert of [turbofan] Correct regalloc blocked register behavior (Closed)

Created:
3 years, 11 months ago by ahaas
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, ahaas
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Correct regalloc blocked register behavior (patchset #2 id:60001 of https://codereview.chromium.org/2652153005/ ) Reason for revert: Introduces new crashers, e.g. load("test/mjsunit/wasm/wasm-constants.js"); load("test/mjsunit/wasm/wasm-module-builder.js"); (function() { var builder = new WasmModuleBuilder(); builder.addMemory(16, 32, false); builder.addFunction("test", kSig_i_iii) .addBodyWithEnd([ // body: kExprI64Const, 0x42, kExprI64Const, 0x7a, kExprI64Ctz, kExprI64Mul, kExprI64Ctz, kExprI64Const, 0x41, kExprI64Ctz, kExprI64Ctz, kExprI64Shl, kExprI64Const, 0x41, kExprI64Ctz, kExprI64Ctz, kExprI64Shl, kExprF32SConvertI64, kExprUnreachable, kExprEnd, // @20 ]) .exportFunc(); var module = builder.instantiate(); module.exports.test(1, 2, 3); })(); Original issue's description: > [turbofan] Correct regalloc blocked register behavior > > > This corrects the case when we need to allocate a > blocked register, but the blockage happens after a > use as an instruction input, and there's no place to > split before that. > > BUG=v8:5888 > > Review-Url: https://codereview.chromium.org/2652153005 > Cr-Commit-Position: refs/heads/master@{#42706} > Committed: https://chromium.googlesource.com/v8/v8/+/ca779b29a60785d962d7cd636f6b0f09e66130b3 TBR=bmeurer@chromium.org,jarin@chromium.org,mtrofin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5888 Review-Url: https://codereview.chromium.org/2654993007 Cr-Commit-Position: refs/heads/master@{#42707} Committed: https://chromium.googlesource.com/v8/v8/+/2b97f79afa3e24829c8b78a64dd9a6978e454f97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -69 lines) Patch
M src/compiler/register-allocator.cc View 1 chunk +1 line, -20 lines 0 comments Download
D test/mjsunit/regress/regress-5888.js View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ahaas
Created Revert of [turbofan] Correct regalloc blocked register behavior
3 years, 11 months ago (2017-01-26 16:05:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654993007/1
3 years, 11 months ago (2017-01-26 16:05:31 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 16:05:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2b97f79afa3e24829c8b78a64dd9a6978e4...

Powered by Google App Engine
This is Rietveld 408576698