[turbofan] Correct regalloc blocked register behavior

[turbofan] Correct regalloc blocked register behavior


This corrects the case when we need to allocate a
blocked register, but the blockage happens after a
use as an instruction input, and there's no place to
split before that.

BUG=v8:5888
Review-Url: https://codereview.chromium.org/2652153005
Cr-Original-Commit-Position: refs/heads/master@{#42706}
Committed: https://chromium.googlesource.com/v8/v8/+/ca779b29a60785d962d7cd636f6b0f09e66130b3
Review-Url: https://codereview.chromium.org/2652153005
Cr-Commit-Position: refs/heads/master@{#42710}
Committed: https://chromium.googlesource.com/v8/v8/+/70fdac9a642154307fa461b2aae38942600c9623

[Mircea Trofin, 2017-01-26 05:54:09]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 05:54:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2017-01-26 06:00:13]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 06:00:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2017-01-26 06:12:15]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 06:12:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2017-01-26 06:12:43]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 06:12:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2017-01-26 06:36:53]

Patchset #1 (id:1) has been deleted

[Mircea Trofin, 2017-01-26 06:37:05]

Patchset #1 (id:20001) has been deleted

[Mircea Trofin, 2017-01-26 06:37:41]

Description was changed from

==========
[turbofan] Correct regalloc blocked register behavior


This corrects the case when we need to allocate a
blocked register, but the blockage happens after a
use as an instruction input, and there's no place to
split before that.

BUG=v8:5888
==========

to

==========
[turbofan] Correct regalloc blocked register behavior


This corrects the case when we need to allocate a
blocked register, but the blockage happens after a
use as an instruction input, and there's no place to
split before that.

BUG=v8:5888
==========

[Mircea Trofin, 2017-01-26 06:37:41]

mtrofin@chromium.org changed reviewers:
+ bmeurer@chromium.org, jarin@chromium.org

[commit-bot: I haz the power, 2017-01-26 06:43:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 06:43:37]

Dry run: This issue passed the CQ dry run.

[Jarin, 2017-01-26 15:42:16]

lgtm (even though I do not fully understand what is going on here).

[Mircea Trofin, 2017-01-26 15:49:49]

The CQ bit was checked by mtrofin@chromium.org

[commit-bot: I haz the power, 2017-01-26 15:49:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 15:51:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485445789804250,
"parent_rev": "842748006dfb92b46bf2dcb2b1ac64f75c355324", "commit_rev":
"ca779b29a60785d962d7cd636f6b0f09e66130b3"}

[commit-bot: I haz the power, 2017-01-26 15:51:52]

Description was changed from

==========
[turbofan] Correct regalloc blocked register behavior


This corrects the case when we need to allocate a
blocked register, but the blockage happens after a
use as an instruction input, and there's no place to
split before that.

BUG=v8:5888
==========

to

==========
[turbofan] Correct regalloc blocked register behavior


This corrects the case when we need to allocate a
blocked register, but the blockage happens after a
use as an instruction input, and there's no place to
split before that.

BUG=v8:5888

Review-Url: https://codereview.chromium.org/2652153005
Cr-Commit-Position: refs/heads/master@{#42706}
Committed:
https://chromium.googlesource.com/v8/v8/+/ca779b29a60785d962d7cd636f6b0f09e66...
==========

[commit-bot: I haz the power, 2017-01-26 15:51:56]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/ca779b29a60785d962d7cd636f6b0f09e66...

[ahaas, 2017-01-26 16:05:22]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/2654993007/ by ahaas@chromium.org.

The reason for reverting is: Introduces new crashers, e.g.

load("test/mjsunit/wasm/wasm-constants.js");
load("test/mjsunit/wasm/wasm-module-builder.js");

(function() {
  var builder = new WasmModuleBuilder();
  builder.addMemory(16, 32, false);
  builder.addFunction("test", kSig_i_iii)
    .addBodyWithEnd([
// body: 
kExprI64Const, 0x42,
kExprI64Const, 0x7a,
kExprI64Ctz,
kExprI64Mul,
kExprI64Ctz,
kExprI64Const, 0x41,
kExprI64Ctz,
kExprI64Ctz,
kExprI64Shl,
kExprI64Const, 0x41,
kExprI64Ctz,
kExprI64Ctz,
kExprI64Shl,
kExprF32SConvertI64,
kExprUnreachable,
kExprEnd,   // @20
            ])
            .exportFunc();
  var module = builder.instantiate();
  module.exports.test(1, 2, 3);
})();.

[Mircea Trofin, 2017-01-26 17:13:55]

Description was changed from

==========
[turbofan] Correct regalloc blocked register behavior


This corrects the case when we need to allocate a
blocked register, but the blockage happens after a
use as an instruction input, and there's no place to
split before that.

BUG=v8:5888

Review-Url: https://codereview.chromium.org/2652153005
Cr-Commit-Position: refs/heads/master@{#42706}
Committed:
https://chromium.googlesource.com/v8/v8/+/ca779b29a60785d962d7cd636f6b0f09e66...
==========

to

==========
[turbofan] Correct regalloc blocked register behavior


This corrects the case when we need to allocate a
blocked register, but the blockage happens after a
use as an instruction input, and there's no place to
split before that.

BUG=v8:5888

Review-Url: https://codereview.chromium.org/2652153005
Cr-Commit-Position: refs/heads/master@{#42706}
Committed:
https://chromium.googlesource.com/v8/v8/+/ca779b29a60785d962d7cd636f6b0f09e66...
==========

[Mircea Trofin, 2017-01-26 17:14:07]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 17:14:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 17:44:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 17:44:58]

Dry run: This issue passed the CQ dry run.

[Mircea Trofin, 2017-01-26 17:46:06]

The CQ bit was checked by mtrofin@chromium.org

[Mircea Trofin, 2017-01-26 17:46:06]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2652153005/#ps80001
(title: "Handle case when range ends at the instruction with blocking regs")

[commit-bot: I haz the power, 2017-01-26 17:46:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 17:47:55]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485452766505990,
"parent_rev": "a8a432701fee76967417be5b17e215ed961c9003", "commit_rev":
"70fdac9a642154307fa461b2aae38942600c9623"}

[commit-bot: I haz the power, 2017-01-26 17:47:59]

Description was changed from

==========
[turbofan] Correct regalloc blocked register behavior


This corrects the case when we need to allocate a
blocked register, but the blockage happens after a
use as an instruction input, and there's no place to
split before that.

BUG=v8:5888

Review-Url: https://codereview.chromium.org/2652153005
Cr-Commit-Position: refs/heads/master@{#42706}
Committed:
https://chromium.googlesource.com/v8/v8/+/ca779b29a60785d962d7cd636f6b0f09e66...
==========

to

==========
[turbofan] Correct regalloc blocked register behavior


This corrects the case when we need to allocate a
blocked register, but the blockage happens after a
use as an instruction input, and there's no place to
split before that.

BUG=v8:5888

Review-Url: https://codereview.chromium.org/2652153005
Cr-Original-Commit-Position: refs/heads/master@{#42706}
Committed:
https://chromium.googlesource.com/v8/v8/+/ca779b29a60785d962d7cd636f6b0f09e66...
Review-Url: https://codereview.chromium.org/2652153005
Cr-Commit-Position: refs/heads/master@{#42710}
Committed:
https://chromium.googlesource.com/v8/v8/+/70fdac9a642154307fa461b2aae38942600...
==========

[commit-bot: I haz the power, 2017-01-26 17:48:00]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/70fdac9a642154307fa461b2aae38942600...