Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2654993005: Reland of ll buildtools 8e94621c36..a7cc7a3e21 (Closed)

Created:
3 years, 11 months ago by Dirk Pranke
Modified:
3 years, 11 months ago
Reviewers:
brettw, maniscalco
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of ll buildtools 8e94621c36..a7cc7a3e21 (patchset #1 id:1 of https://codereview.chromium.org/2657603005/ ) Reason for revert: This patchset was not to blame for the failure; I think the failure is a missing dependency as noted in crbug.com/685440. So, re-landing. Original issue's description: > Revert of Roll buildtools 8e94621c36..a7cc7a3e21 (patchset #1 id:1 of https://codereview.chromium.org/2653303002/ ) > > Reason for revert: > Suspecting as cause of build breakage: https://build.chromium.org/p/chromium/builders/Win/builds/51253 > > > > Original issue's description: > > Roll buildtools 8e94621c36..a7cc7a3e21 > > > > In order to roll GN f13158d3c5..d8754536ca (r445411:r446079) and pick up > > the following changes: > > > > 9257ae440105 Display override values in GN args help. > > 23449b778105 Add ftplugin for gn filetype > > > > TBR=dpranke@chromium.org > > > > Review-Url: https://codereview.chromium.org/2653303002 > > Cr-Commit-Position: refs/heads/master@{#446164} > > Committed: https://chromium.googlesource.com/chromium/src/+/04735ada30b9ba63031fdeebcf2d20f2249814ba > > TBR=dpranke@chromium.org,brettw@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Review-Url: https://codereview.chromium.org/2657603005 > Cr-Commit-Position: refs/heads/master@{#446175} > Committed: https://chromium.googlesource.com/chromium/src/+/cdbf95d14d37a34ee38758235db4ff3b1667a333 TBR=brettw@chromium.org,maniscalco@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2654993005 Cr-Commit-Position: refs/heads/master@{#446185} Committed: https://chromium.googlesource.com/chromium/src/+/f21a35d01fe3fbab752736526b6dbaa31172c310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Dirk Pranke
Created Reland of ll buildtools 8e94621c36..a7cc7a3e21
3 years, 11 months ago (2017-01-26 01:04:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654993005/1
3 years, 11 months ago (2017-01-26 01:05:56 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 01:12:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f21a35d01fe3fbab752736526b6d...

Powered by Google App Engine
This is Rietveld 408576698