Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2653303002: Roll buildtools 8e94621c36..a7cc7a3e21 (Closed)

Created:
3 years, 11 months ago by brettw
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 8e94621c36..a7cc7a3e21 In order to roll GN f13158d3c5..d8754536ca (r445411:r446079) and pick up the following changes: 9257ae440105 Display override values in GN args help. 23449b778105 Add ftplugin for gn filetype TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2653303002 Cr-Commit-Position: refs/heads/master@{#446164} Committed: https://chromium.googlesource.com/chromium/src/+/04735ada30b9ba63031fdeebcf2d20f2249814ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
brettw
3 years, 11 months ago (2017-01-25 20:30:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653303002/1
3 years, 11 months ago (2017-01-25 20:30:50 UTC) #3
Dirk Pranke
lgtm
3 years, 11 months ago (2017-01-25 20:31:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/04735ada30b9ba63031fdeebcf2d20f2249814ba
3 years, 11 months ago (2017-01-25 23:35:05 UTC) #7
maniscalco
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2657603005/ by maniscalco@chromium.org. ...
3 years, 11 months ago (2017-01-26 00:38:24 UTC) #8
maniscalco
3 years, 11 months ago (2017-01-26 00:43:18 UTC) #9
Message was sent while issue was closed.
On 2017/01/26 00:38:24, maniscalco wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2657603005/ by mailto:maniscalco@chromium.org.
> 
> The reason for reverting is: Suspecting as cause of build breakage:
> https://build.chromium.org/p/chromium/builders/Win/builds/51253
> 
> .

More context in https://bugs.chromium.org/p/chromium/issues/detail?id=685440

Powered by Google App Engine
This is Rietveld 408576698