Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2654983003:
Panel string changes (Closed)
|
Created:
3 years, 11 months ago by David Tseng Modified:
3 years, 11 months ago Reviewers:
dmazzoni CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPanel string changes
Cleans up string references to panel for each mode.
BUG=684768, 684757
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2654983003
Cr-Commit-Position: refs/heads/master@{#446115}
Committed: https://chromium.googlesource.com/chromium/src/+/333889f407e49eca681b3354547221022f4d622c
Patch Set 1 #
Total comments: 1
Messages
Total messages: 17 (10 generated)
Description was changed from ========== Panel string changes Cleans up string references to panel for each mode. BUG= ========== to ========== Panel string changes Cleans up string references to panel for each mode. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Panel string changes Cleans up string references to panel for each mode. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Panel string changes Cleans up string references to panel for each mode. BUG=684768,684757 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dtseng@chromium.org changed reviewers: + dmazzoni@chromium.org
lgtm but confused about showPowerKey https://codereview.chromium.org/2654983003/diff/1/chrome/browser/resources/ch... File chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd (right): https://codereview.chromium.org/2654983003/diff/1/chrome/browser/resources/ch... chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:184: Open ChromeVox menus Why is this showPowerKey? And if so do you want to change hidePowerKey too?
dmazzoni@chromium.org writes: > lgtm but confused about showPowerKey > > > > https://codereview.chromium.org/2654983003/diff/1/chrome/browser/resources/ch... > File > chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd > (right): > > https://codereview.chromium.org/2654983003/diff/1/chrome/browser/resources/ch... > chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:184: > Open ChromeVox menus > Why is this showPowerKey? And if so do you want to change hidePowerKey > too? Legacy; used by Classic. I'm guessing at one point, there was a shortcut to hide keyboard help/power key which we're now calling ChromeVox menus. > > https://codereview.chromium.org/2654983003/ -- http://www.example.com -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Might be better to just create a new string rather than reusing one from Classic, then? On Wed, Jan 25, 2017 at 9:52 AM <dtseng@chromium.org> wrote: > > dmazzoni@chromium.org writes: > > > lgtm but confused about showPowerKey > > > > > > > > > https://codereview.chromium.org/2654983003/diff/1/chrome/browser/resources/ch... > > File > > chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd > > (right): > > > > > https://codereview.chromium.org/2654983003/diff/1/chrome/browser/resources/ch... > > > chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:184: > > Open ChromeVox menus > > Why is this showPowerKey? And if so do you want to change hidePowerKey > > too? > > Legacy; used by Classic. I'm guessing at one point, there was a shortcut > to hide keyboard help/power key which we're now calling ChromeVox menus. > > > > https://codereview.chromium.org/2654983003/ > > > -- > > http://www.example.com > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to chromium-reviews+unsubscribe@chromium.org. > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
'Dominic Mazzoni' via Chromium-reviews writes: > Might be better to just create a new string rather than reusing one from > Classic, then? > It's tied to the command (i.e. toggleKeyboardHelp). So, one way or another, we're sharing with Classic. Once we can deprecate/remove Classic, we can go back and clean this up. > > On Wed, Jan 25, 2017 at 9:52 AM <dtseng@chromium.org> wrote: > >> >> dmazzoni@chromium.org writes: >> >> > lgtm but confused about showPowerKey >> > >> > >> > >> > >> https://codereview.chromium.org/2654983003/diff/1/chrome/browser/resources/ch... >> > File >> > chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd >> > (right): >> > >> > >> https://codereview.chromium.org/2654983003/diff/1/chrome/browser/resources/ch... >> > >> chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd:184: >> > Open ChromeVox menus >> > Why is this showPowerKey? And if so do you want to change hidePowerKey >> > too? >> >> Legacy; used by Classic. I'm guessing at one point, there was a shortcut >> to hide keyboard help/power key which we're now calling ChromeVox menus. >> > >> > https://codereview.chromium.org/2654983003/ >> >> >> -- >> >> http://www.example.com >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Chromium-reviews" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to chromium-reviews+unsubscribe@chromium.org. >> >> -- Foo X. Bar http://www.example.com -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by dtseng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dtseng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485377146210720, "parent_rev":
"26b60bdb6356ad5319d19b628d76cdf189a78df4", "commit_rev":
"333889f407e49eca681b3354547221022f4d622c"}
Message was sent while issue was closed.
Description was changed from ========== Panel string changes Cleans up string references to panel for each mode. BUG=684768,684757 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Panel string changes Cleans up string references to panel for each mode. BUG=684768,684757 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2654983003 Cr-Commit-Position: refs/heads/master@{#446115} Committed: https://chromium.googlesource.com/chromium/src/+/333889f407e49eca681b33545472... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/333889f407e49eca681b33545472... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
