Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: test/mjsunit/shared-function-tier-up-ignition.js

Issue 2654733004: [tests] Make assertOptimized()/assertUnoptimized() great again. (Closed)
Patch Set: Rebasing for relanding Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/shared-function-tier-up-ignition.js
diff --git a/test/mjsunit/shared-function-tier-up-ignition.js b/test/mjsunit/shared-function-tier-up-ignition.js
index ffbf3a303fc490bbcacbcd66b879922f494d1836..ea05d4e66da1d49066a8f8c02e66481527451380 100644
--- a/test/mjsunit/shared-function-tier-up-ignition.js
+++ b/test/mjsunit/shared-function-tier-up-ignition.js
@@ -6,6 +6,10 @@
// Flags: --ignition-staging --no-turbo
// Flags: --crankshaft --no-always-opt
+// If we are always or never optimizing it is useless.
+assertFalse(isAlwaysOptimize());
+assertFalse(isNeverOptimize());
+
(function() {
var sum = 0;
var i = 0;
@@ -15,29 +19,25 @@
}
sum += f(i);
- if (%GetOptimizationStatus(f) == 3 || %GetOptimizationStatus(f) == 4) {
- // If we are always or never optimizing f, just exit, this test is useless.
- return;
- }
-
if (i == 1) {
// f must be interpreted code.
- assertEquals(8, %GetOptimizationStatus(f));
+ assertTrue(isInterpreted(f));
// Allow it to run twice (i = 0, 1), then tier-up to baseline.
%BaselineFunctionOnNextCall(f);
} else if (i == 2) {
// Tier-up at i = 2 should only go up to baseline.
- assertEquals(2, %GetOptimizationStatus(f));
+ assertTrue(isBaselined(f));
+
} else if (i == 3) {
// Now f must be baseline code.
- assertEquals(2, %GetOptimizationStatus(f));
+ assertTrue(isBaselined(f));
// Run two more times (i = 2, 3), then tier-up to optimized.
%OptimizeFunctionOnNextCall(f);
} else if (i == 4) {
// Tier-up at i = 4 should now go up to crankshaft.
- assertEquals(1, %GetOptimizationStatus(f));
+ assertTrue(isCrankshafted(f));
}
}
})()

Powered by Google App Engine
This is Rietveld 408576698