Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: gni/v8.gni

Issue 2654663003: Conditionally convert V8 build overrides to declare_args. (Closed)
Patch Set: Fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« BUILD.gn ('K') | « build_overrides/v8.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gni/v8.gni
diff --git a/gni/v8.gni b/gni/v8.gni
index cb2bdf2cf5d9a5766ee70d11ff8fefbed02e79ef..1f26674108a2e86dfa7e7824049c99f35ac6ac5f 100644
--- a/gni/v8.gni
+++ b/gni/v8.gni
@@ -35,8 +35,19 @@ declare_args() {
# add a dependency on the ICU library.
v8_enable_i18n_support = true
- # Enable inspector. See include/v8-inspector.h.
- v8_enable_inspector = v8_enable_inspector_override
+ # TODO(brettw) http://crbug.com/684096 Remove the define condition and the
+ # v8_enable_inspector_override variable when the build_override conversion is
+ # complete. This value should just default to true.
+ if (defined(v8_enable_inspector_override)) {
+ # Enable inspector. See include/v8-inspector.h.
+ v8_enable_inspector = v8_enable_inspector_override
+ } else {
+ # Enable inspector. See include/v8-inspector.h.
+ v8_enable_inspector = true
+ }
+
+ # Use static libraries instead of source_sets.
+ v8_static_library = false
}
if (v8_use_external_startup_data == "") {
« BUILD.gn ('K') | « build_overrides/v8.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698