Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: gni/v8.gni

Issue 2654663003: Conditionally convert V8 build overrides to declare_args. (Closed)
Patch Set: Fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« BUILD.gn ('K') | « build_overrides/v8.gni ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 the V8 project authors. All rights reserved. 1 # Copyright 2016 the V8 project authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni") 5 import("//build/config/sanitizers/sanitizers.gni")
6 import("//build/config/v8_target_cpu.gni") 6 import("//build/config/v8_target_cpu.gni")
7 import("//build_overrides/v8.gni") 7 import("//build_overrides/v8.gni")
8 8
9 declare_args() { 9 declare_args() {
10 # Includes files needed for correctness fuzzing. 10 # Includes files needed for correctness fuzzing.
(...skipping 17 matching lines...) Expand all
28 v8_use_snapshot = true 28 v8_use_snapshot = true
29 29
30 # Use external files for startup data blobs: 30 # Use external files for startup data blobs:
31 # the JS builtins sources and the start snapshot. 31 # the JS builtins sources and the start snapshot.
32 v8_use_external_startup_data = "" 32 v8_use_external_startup_data = ""
33 33
34 # Enable ECMAScript Internationalization API. Enabling this feature will 34 # Enable ECMAScript Internationalization API. Enabling this feature will
35 # add a dependency on the ICU library. 35 # add a dependency on the ICU library.
36 v8_enable_i18n_support = true 36 v8_enable_i18n_support = true
37 37
38 # Enable inspector. See include/v8-inspector.h. 38 # TODO(brettw) http://crbug.com/684096 Remove the define condition and the
39 v8_enable_inspector = v8_enable_inspector_override 39 # v8_enable_inspector_override variable when the build_override conversion is
40 # complete. This value should just default to true.
41 if (defined(v8_enable_inspector_override)) {
42 # Enable inspector. See include/v8-inspector.h.
43 v8_enable_inspector = v8_enable_inspector_override
44 } else {
45 # Enable inspector. See include/v8-inspector.h.
46 v8_enable_inspector = true
47 }
48
49 # Use static libraries instead of source_sets.
50 v8_static_library = false
40 } 51 }
41 52
42 if (v8_use_external_startup_data == "") { 53 if (v8_use_external_startup_data == "") {
43 # If not specified as a gn arg, use external startup data by default if 54 # If not specified as a gn arg, use external startup data by default if
44 # a snapshot is used and if we're not on ios. 55 # a snapshot is used and if we're not on ios.
45 v8_use_external_startup_data = v8_use_snapshot && !is_ios 56 v8_use_external_startup_data = v8_use_snapshot && !is_ios
46 } 57 }
47 58
48 if (v8_enable_backtrace == "") { 59 if (v8_enable_backtrace == "") {
49 v8_enable_backtrace = is_debug && !v8_optimized_debug 60 v8_enable_backtrace = is_debug && !v8_optimized_debug
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 } 140 }
130 141
131 template("v8_component") { 142 template("v8_component") {
132 component(target_name) { 143 component(target_name) {
133 forward_variables_from(invoker, "*", [ "configs" ]) 144 forward_variables_from(invoker, "*", [ "configs" ])
134 configs += invoker.configs 145 configs += invoker.configs
135 configs -= v8_remove_configs 146 configs -= v8_remove_configs
136 configs += v8_add_configs 147 configs += v8_add_configs
137 } 148 }
138 } 149 }
OLDNEW
« BUILD.gn ('K') | « build_overrides/v8.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698