Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: build_overrides/v8.gni

Issue 2654663003: Conditionally convert V8 build overrides to declare_args. (Closed)
Patch Set: Fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« BUILD.gn ('K') | « BUILD.gn ('k') | gni/v8.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_overrides/v8.gni
diff --git a/build_overrides/v8.gni b/build_overrides/v8.gni
index 15a50558610fa0592b9c91239e87562ee9c4f78a..d44b16246b6ac45a99c9dfa2b054615bf44bffd1 100644
--- a/build_overrides/v8.gni
+++ b/build_overrides/v8.gni
@@ -2,24 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("//build/config/v8_target_cpu.gni")
+# This file should be empty.
-if (((v8_current_cpu == "x86" || v8_current_cpu == "x64" ||
- v8_current_cpu == "x87") && (is_linux || is_mac)) ||
- (v8_current_cpu == "ppc64" && is_linux)) {
- v8_enable_gdbjit_default = true
-}
-
-v8_imminent_deprecation_warnings_default = true
-
-# Add simple extras solely for the purpose of the cctests.
-v8_extra_library_files = [ "//test/cctest/test-extra.js" ]
-v8_experimental_extra_library_files =
- [ "//test/cctest/test-experimental-extra.js" ]
-
-v8_enable_inspector_override = true
-
-declare_args() {
- # Use static libraries instead of source_sets.
- v8_static_library = false
-}
+# TODO(brettw) http://crbug.com/684096 Remove this when all callers are updated
+# to use the new build overrides system.
« BUILD.gn ('K') | « BUILD.gn ('k') | gni/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698