Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2654653004: Remove SurfaceReferenceManager interface. (Closed)

Created:
3 years, 11 months ago by kylechar
Modified:
3 years, 10 months ago
CC:
chromium-reviews, rjkroege, cc-bugs_chromium.org, Saman Sami
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SurfaceReferenceManager interface. The interface is no longer necessary for tests. Delete the interface and move method comments to SurfaceManager. Cleanup the last references to the interface in DisplayCompositor. Also removes the GetSurfaceReferenceCount() / GetReferenceSurfaceCount() methods that are unused. We don't care about the number of references, we care about reachable from the top-level root. BUG=659227 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2654653004 Cr-Commit-Position: refs/heads/master@{#446687} Committed: https://chromium.googlesource.com/chromium/src/+/a5af59cbbaccb5f6705e2e3b6c62984c21a398e1

Patch Set 1 #

Patch Set 2 : Rebase cleanup. #

Patch Set 3 : Rebase + fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -122 lines) Patch
M cc/surfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M cc/surfaces/surface_manager.h View 1 2 5 chunks +22 lines, -15 lines 0 comments Download
M cc/surfaces/surface_manager.cc View 1 2 2 chunks +1 line, -18 lines 0 comments Download
M cc/surfaces/surface_manager_ref_unittest.cc View 1 2 9 chunks +24 lines, -19 lines 0 comments Download
D cc/surfaces/surface_reference_manager.h View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
M services/ui/surfaces/display_compositor.h View 1 2 3 chunks +0 lines, -7 lines 0 comments Download
M services/ui/surfaces/display_compositor.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
kylechar
jbauman: cc/surfaces/* fsamuel: services/ui/surfaces/*
3 years, 10 months ago (2017-01-25 19:47:12 UTC) #5
Fady Samuel
Thanks for the cleanup! LGTM
3 years, 10 months ago (2017-01-25 19:50:02 UTC) #6
xing.xu
LGTM. BTW, this may conflicts with https://codereview.chromium.org/2654693003/
3 years, 10 months ago (2017-01-26 01:43:46 UTC) #7
jbauman
lgtm
3 years, 10 months ago (2017-01-26 02:08:08 UTC) #8
kylechar
Thanks!
3 years, 10 months ago (2017-01-27 16:35:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654653004/80001
3 years, 10 months ago (2017-01-27 16:35:39 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 16:46:09 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a5af59cbbaccb5f6705e2e3b6c62...

Powered by Google App Engine
This is Rietveld 408576698