Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2480)

Unified Diff: cc/surfaces/surface_manager.cc

Issue 2654653004: Remove SurfaceReferenceManager interface. (Closed)
Patch Set: Rebase + fix tests. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_manager.h ('k') | cc/surfaces/surface_manager_ref_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_manager.cc
diff --git a/cc/surfaces/surface_manager.cc b/cc/surfaces/surface_manager.cc
index cfdc7a112a4776136bad76d3166f31ca6023a496..dd75af7855d8e0fa6100b4a4ebab5d124a30ce65 100644
--- a/cc/surfaces/surface_manager.cc
+++ b/cc/surfaces/surface_manager.cc
@@ -216,7 +216,6 @@ void SurfaceManager::RemoveSurfaceReference(const SurfaceId& parent_id,
}
RemoveSurfaceReferenceImpl(parent_id, child_id);
- GarbageCollectSurfaces();
}
void SurfaceManager::AddSurfaceReferences(
@@ -231,26 +230,10 @@ void SurfaceManager::RemoveSurfaceReferences(
const std::vector<SurfaceReference>& references) {
DCHECK(thread_checker_.CalledOnValidThread());
- // TODO(kylechar): Each remove reference can trigger GC, it would be better if
- // we GC only once if removing multiple references.
for (const auto& reference : references)
RemoveSurfaceReference(reference.parent_id(), reference.child_id());
-}
-
-size_t SurfaceManager::GetSurfaceReferenceCount(
- const SurfaceId& surface_id) const {
- auto iter = child_to_parent_refs_.find(surface_id);
- if (iter == child_to_parent_refs_.end())
- return 0;
- return iter->second.size();
-}
-size_t SurfaceManager::GetReferencedSurfaceCount(
- const SurfaceId& surface_id) const {
- auto iter = parent_to_child_refs_.find(surface_id);
- if (iter == parent_to_child_refs_.end())
- return 0;
- return iter->second.size();
+ GarbageCollectSurfaces();
}
void SurfaceManager::GarbageCollectSurfaces() {
« no previous file with comments | « cc/surfaces/surface_manager.h ('k') | cc/surfaces/surface_manager_ref_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698