Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2654463003: DevTools: render (verbose|info) (intervensions|deprecations|violations) with warning background. (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: render (verbose|info) (intervensions|deprecations|violations) with warning background. BUG=682521 Review-Url: https://codereview.chromium.org/2654463003 Cr-Commit-Position: refs/heads/master@{#445871} Committed: https://chromium.googlesource.com/chromium/src/+/457a88fd89428662bf2c03309b7d266268ebde3a

Patch Set 1 #

Total comments: 1

Patch Set 2 : tests rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/console-resource-errors-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
pfeldman
3 years, 11 months ago (2017-01-23 22:11:07 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2654463003/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/2654463003/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode953 third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:953: this._element.classList.add('console-warning-level'); Doesn't this add a warning icon as ...
3 years, 11 months ago (2017-01-23 23:29:12 UTC) #3
pfeldman
On 2017/01/23 23:29:12, dgozman wrote: > lgtm > > https://codereview.chromium.org/2654463003/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js > File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js > (right): ...
3 years, 11 months ago (2017-01-24 00:37:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654463003/1
3 years, 11 months ago (2017-01-24 00:38:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/376486)
3 years, 11 months ago (2017-01-24 02:07:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654463003/20001
3 years, 11 months ago (2017-01-24 18:49:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/375097)
3 years, 11 months ago (2017-01-24 20:53:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654463003/20001
3 years, 11 months ago (2017-01-24 22:48:41 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 00:16:34 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/457a88fd89428662bf2c03309b7d...

Powered by Google App Engine
This is Rietveld 408576698