Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2654463003: DevTools: render (verbose|info) (intervensions|deprecations|violations) with warning background. (Closed)
Patch Set: tests rebaselined Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 8c62058d640b367a3f0953535898d39f52fb1c71..9e0dd83c0a025ab2628e7846ac6bb6d13f483c4e 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -249,6 +249,10 @@ Console.ConsoleViewMessage = class {
} else {
if (consoleMessage.source === SDK.ConsoleMessage.MessageSource.Violation)
messageText = Common.UIString('[Violation] %s', messageText);
+ else if (consoleMessage.source === SDK.ConsoleMessage.MessageSource.Intervention)
+ messageText = Common.UIString('[Intervention] %s', messageText);
+ if (consoleMessage.source === SDK.ConsoleMessage.MessageSource.Deprecation)
+ messageText = Common.UIString('[Deprecation] %s', messageText);
var args = consoleMessage.parameters || [messageText];
messageElement = this._format(args);
}
@@ -939,6 +943,18 @@ Console.ConsoleViewMessage = class {
break;
}
+ // Render verbose and info deprecations, interventions and violations with warning background.
+ if (this._message.level === SDK.ConsoleMessage.MessageLevel.Verbose ||
+ this._message.level === SDK.ConsoleMessage.MessageLevel.Info) {
+ switch (this._message.source) {
+ case SDK.ConsoleMessage.MessageSource.Violation:
+ case SDK.ConsoleMessage.MessageSource.Deprecation:
+ case SDK.ConsoleMessage.MessageSource.Intervention:
+ this._element.classList.add('console-warning-level');
+ break;
+ }
+ }
+
this._element.appendChild(this.contentElement());
if (this._repeatCount > 1)
this._showRepeatCountElement();
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698