[foozzie] Improve mocking stack traces

[foozzie] Improve mocking stack traces

BUG=chromium:685633
NOTRY=true

Review-Url: https://codereview.chromium.org/2654273004
Cr-Commit-Position: refs/heads/master@{#42728}
Committed: https://chromium.googlesource.com/v8/v8/+/21340ded47dad7a6bd02a8a4c9eca2a223c9bb3d

[Michael Achenbach, 2017-01-27 08:41:46]

Description was changed from

==========
[foozzie] Improve mocking stack traces

BUG=
==========

to

==========
[foozzie] Improve mocking stack traces

BUG=chromium:685633
NOTRY=true
==========

[Michael Achenbach, 2017-01-27 08:41:46]

machenbach@chromium.org changed reviewers:
+ jarin@chromium.org, yangguo@chromium.org

[Michael Achenbach, 2017-01-27 08:42:16]

PTAL

[Yang, 2017-01-27 08:43:38]

lgtm

https://codereview.chromium.org/2654273004/diff/1/tools/foozzie/v8_mock.js
File tools/foozzie/v8_mock.js (right):

https://codereview.chromium.org/2654273004/diff/1/tools/foozzie/v8_mock.js#ne...
tools/foozzie/v8_mock.js:58: Object.defineProperty(Error, 'prepareStackTrace', {
writable: false });
if you dont make it non configurable you can still use defineProperty to make it
writable again :)

[Michael Achenbach, 2017-01-27 08:46:41]

https://codereview.chromium.org/2654273004/diff/1/tools/foozzie/v8_mock.js
File tools/foozzie/v8_mock.js (right):

https://codereview.chromium.org/2654273004/diff/1/tools/foozzie/v8_mock.js#ne...
tools/foozzie/v8_mock.js:58: Object.defineProperty(Error, 'prepareStackTrace', {
writable: false });
On 2017/01/27 08:43:38, Yang wrote:
> if you dont make it non configurable you can still use defineProperty to make
it
> writable again :)

Argh! Done...

[Michael Achenbach, 2017-01-27 08:47:11]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2017-01-27 08:47:11]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2654273004/#ps40001
(title: "Review")

[commit-bot: I haz the power, 2017-01-27 08:47:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 08:49:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485506831444040,
"parent_rev": "fd918b595b66d6e26c99d508d8a84e7da2f044ce", "commit_rev":
"21340ded47dad7a6bd02a8a4c9eca2a223c9bb3d"}

[commit-bot: I haz the power, 2017-01-27 08:49:45]

Description was changed from

==========
[foozzie] Improve mocking stack traces

BUG=chromium:685633
NOTRY=true
==========

to

==========
[foozzie] Improve mocking stack traces

BUG=chromium:685633
NOTRY=true

Review-Url: https://codereview.chromium.org/2654273004
Cr-Commit-Position: refs/heads/master@{#42728}
Committed:
https://chromium.googlesource.com/v8/v8/+/21340ded47dad7a6bd02a8a4c9eca2a223c...
==========

[commit-bot: I haz the power, 2017-01-27 08:49:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/21340ded47dad7a6bd02a8a4c9eca2a223c...