tools/foozzie/v8_mock.js - Issue 2654273004: [foozzie] Improve mocking stack traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/foozzie/v8_mock.js

Issue 2654273004: [foozzie] Improve mocking stack traces (Closed)

Patch Set: Review Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/foozzie/v8_mock.js

diff --git a/tools/foozzie/v8_mock.js b/tools/foozzie/v8_mock.js

index 4bd3ce54025988eb647ceb60a135453e3f1f92e3..647730af1ea2f97564ee01b45691ebacec512067 100644

--- a/tools/foozzie/v8_mock.js

+++ b/tools/foozzie/v8_mock.js

@@ -55,7 +55,8 @@ var __PrettyPrint = function __PrettyPrint(msg) { print(msg); };

Error.prepareStackTrace = function (error, structuredStackTrace) {

return "";

};

-Object.freeze(Error)

+Object.defineProperty(

+ Error, 'prepareStackTrace', { configurable: false, writable: false });

// Mock buffer access in float typed arrays because of varying NaN patterns.

// Note, for now we just use noop forwarding proxies, because they already

« no previous file with comments | « no previous file | no next file » | no next file with comments »