Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 2654233002: Revert of [regexp] Create property on result for each named capture (Closed)

Created:
3 years, 11 months ago by jgruber
Modified:
3 years, 11 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
Dan Ehrenberg
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Create property on result for each named capture (patchset #9 id:160001 of https://codereview.chromium.org/2630233003/ ) Reason for revert: Some heap tests are broken leading to failures on nosnap builds: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/3677 Reverting again until tests are fixed to keep bots green. Original issue's description: > [regexp] Store named captures on the regexp result > > This implements storing named captures on the regexp result object. > For instance, /(?<a>.)/u.exec("b") will return a result such that: > > result.group.a // "b" > > https://tc39.github.io/proposal-regexp-named-groups/ > > BUG=v8:5437 > > Review-Url: https://codereview.chromium.org/2630233003 > Cr-Original-Original-Commit-Position: refs/heads/master@{#42532} > Committed: https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1fcf154 > Review-Url: https://codereview.chromium.org/2630233003 > Cr-Original-Commit-Position: refs/heads/master@{#42570} > Committed: https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e502396c > Review-Url: https://codereview.chromium.org/2630233003 > Cr-Commit-Position: refs/heads/master@{#42676} > Committed: https://chromium.googlesource.com/v8/v8/+/8bf52534f6bf86821a1589dcbcb7335052c1f94f TBR=yangguo@chromium.org,littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5437 Review-Url: https://codereview.chromium.org/2654233002 Cr-Commit-Position: refs/heads/master@{#42681} Committed: https://chromium.googlesource.com/v8/v8/+/25bfdf1b46f21435343cd94b31add664395db146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -124 lines) Patch
M src/builtins/builtins-regexp.cc View 7 chunks +11 lines, -89 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-named-captures.js View 2 chunks +9 lines, -31 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jgruber
Created Revert of [regexp] Create property on result for each named capture
3 years, 11 months ago (2017-01-26 09:29:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654233002/1
3 years, 11 months ago (2017-01-26 09:30:02 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 09:31:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/25bfdf1b46f21435343cd94b31add664395...

Powered by Google App Engine
This is Rietveld 408576698