[regexp] Create property on result for each named capture

[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

https://tc39.github.io/proposal-regexp-named-groups/

BUG=v8:5437
Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#42532}
Committed: https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1fcf154
Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Original-Commit-Position: refs/heads/master@{#42570}
Committed: https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e502396c
Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Commit-Position: refs/heads/master@{#42676}
Committed: https://chromium.googlesource.com/v8/v8/+/8bf52534f6bf86821a1589dcbcb7335052c1f94f
Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42838}
Committed: https://chromium.googlesource.com/v8/v8/+/d52ec9e6cfb0c5ad81d614b11957cb85fba06d96

[jgruber, 2017-01-16 08:32:15]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 08:32:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 09:00:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 09:00:59]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-01-17 09:13:55]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 09:14:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-17 09:26:50]

jgruber@chromium.org changed reviewers:
+ littledan@chromium.org, yangguo@chromium.org

[jgruber, 2017-01-17 09:26:51]

This adds capture properties to the RegExp result, implemented to match the
draft spec at https://tc39.github.io/proposal-regexp-named-groups/.

TODO: Function replace interaction with named captures.
TODO: Possible optimizations for the non-named-capture exec case (we can save 1
load and 1 branch).

https://codereview.chromium.org/2630233003/diff/20001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2630233003/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:214: Node* const data = LoadObjectField(regexp,
JSRegExp::kDataOffset);
This unconditionally adds two loads and two branches to each exec path. 

I'd like to see the impact before optimizing; packing a new internal flag into
JSRegExp::Flags isn't completely trivial since e.g. flags are sometimes
reconstructed from the flags string.

https://codereview.chromium.org/2630233003/diff/20001/src/regexp/regexp-parse...
File src/regexp/regexp-parser.cc (right):

https://codereview.chromium.org/2630233003/diff/20001/src/regexp/regexp-parse...
src/regexp/regexp-parser.cc:771: static std::vector<uc16> illegal_names[] = {
The final proposal might not need this blacklist if captures aren't stored
directly on the result.

[commit-bot: I haz the power, 2017-01-17 09:42:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 09:42:40]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-01-17 13:35:43]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 13:35:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 14:09:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 14:09:35]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-01-18 13:25:37]

lgtm.

https://codereview.chromium.org/2630233003/diff/20001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2630233003/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:214: Node* const data = LoadObjectField(regexp,
JSRegExp::kDataOffset);
On 2017/01/17 09:26:51, jgruber wrote:
> This unconditionally adds two loads and two branches to each exec path. 
> 
> I'd like to see the impact before optimizing; packing a new internal flag into
> JSRegExp::Flags isn't completely trivial since e.g. flags are sometimes
> reconstructed from the flags string.

I think we can already make this a bit simpler: we only need to care about named
captures if we have any captures at all. If we have captures, then it cannot be
an atom regexp, so the tag check is redundant too.

https://codereview.chromium.org/2630233003/diff/40001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2630233003/diff/40001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:222: GotoIf(SmiEqual(names, SmiConstant(0)),
&out);
Why don't we jump to runtime after this? That would be more readable and we'd
only call into runtime once, instead once for every property.

https://codereview.chromium.org/2630233003/diff/40001/src/regexp/regexp-parse...
File src/regexp/regexp-parser.cc (right):

https://codereview.chromium.org/2630233003/diff/40001/src/regexp/regexp-parse...
src/regexp/regexp-parser.cc:773: 'i', 'n', 'd', 'e', 'x',
Is it possible to use wide string literals here?
http://en.cppreference.com/w/cpp/language/string_literal

[Dan Ehrenberg, 2017-01-18 18:19:04]

lgtm

Based on your feedback, I'll change the spec to use a groups object. Maybe this
should wait to land until I get that version, OTOH this is not yet staged so if
it seems beneficial to you to land an intermediate version, go for it.

https://codereview.chromium.org/2630233003/diff/40001/test/mjsunit/harmony/re...
File test/mjsunit/harmony/regexp-named-captures.js (right):

https://codereview.chromium.org/2630233003/diff/40001/test/mjsunit/harmony/re...
test/mjsunit/harmony/regexp-named-captures.js:96: assertThrows('/(?<𐒤>a)/u'); 
// ID_Continue but not ID_Start.
For syntax error tests, how about assertThrows('/(?<𐒤>a)/u', SyntaxError) to be
more specific?

[jgruber, 2017-01-19 13:53:53]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 13:53:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 14:29:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 14:29:48]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-01-19 15:51:12]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 15:51:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-19 15:59:12]

Thanks for the reviews, comments addressed. 

I updated this to store captures on a result.group object (the most common name
from http://xregexp.com/syntax/named_capture_comparison/), and blacklisted
__proto__ as a capture name.

https://codereview.chromium.org/2630233003/diff/20001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2630233003/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:214: Node* const data = LoadObjectField(regexp,
JSRegExp::kDataOffset);
On 2017/01/18 13:25:36, Yang wrote:
> On 2017/01/17 09:26:51, jgruber wrote:
> > This unconditionally adds two loads and two branches to each exec path. 
> > 
> > I'd like to see the impact before optimizing; packing a new internal flag
into
> > JSRegExp::Flags isn't completely trivial since e.g. flags are sometimes
> > reconstructed from the flags string.
> 
> I think we can already make this a bit simpler: we only need to care about
named
> captures if we have any captures at all. If we have captures, then it cannot
be
> an atom regexp, so the tag check is redundant too.

Very good point, done.

https://codereview.chromium.org/2630233003/diff/40001/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2630233003/diff/40001/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:222: GotoIf(SmiEqual(names, SmiConstant(0)),
&out);
On 2017/01/18 13:25:36, Yang wrote:
> Why don't we jump to runtime after this? That would be more readable and we'd
> only call into runtime once, instead once for every property.

Once the SetPropertyStub is implemented we'll be able to completely avoid
calling into runtime here, this is written with that in mind.

https://codereview.chromium.org/2630233003/diff/40001/src/regexp/regexp-parse...
File src/regexp/regexp-parser.cc (right):

https://codereview.chromium.org/2630233003/diff/40001/src/regexp/regexp-parse...
src/regexp/regexp-parser.cc:773: 'i', 'n', 'd', 'e', 'x',
On 2017/01/18 13:25:36, Yang wrote:
> Is it possible to use wide string literals here?
> http://en.cppreference.com/w/cpp/language/string_literal

I didn't find a way to do that for this use case. The solution above works
because we use the C++11 initializer list constructor. That doesn't fly anymore
when using wide string literals since that produces 'const char16[6]' and 'const
char16[7]' types.

Anyway, it looks like the blacklist will only consist of __proto__ and we can
definitely use wide string literals in that case.

https://codereview.chromium.org/2630233003/diff/40001/test/mjsunit/harmony/re...
File test/mjsunit/harmony/regexp-named-captures.js (right):

https://codereview.chromium.org/2630233003/diff/40001/test/mjsunit/harmony/re...
test/mjsunit/harmony/regexp-named-captures.js:96: assertThrows('/(?<𐒤>a)/u'); 
// ID_Continue but not ID_Start.
On 2017/01/18 18:19:04, Dan Ehrenberg wrote:
> For syntax error tests, how about assertThrows('/(?<𐒤>a)/u', SyntaxError) to
be
> more specific?

Done.

[jgruber, 2017-01-19 16:10:59]

Description was changed from

==========
[regexp] Create property on result for each named capture

BUG=
==========

to

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

The spec proposal is not yet final, so this may still change in the future.

BUG=v8:5437
==========

[commit-bot: I haz the power, 2017-01-19 16:31:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 16:31:57]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-01-20 08:01:57]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-01-20 08:01:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2630233003/#ps80001
(title: "Address comments and switch to 'group' property")

[commit-bot: I haz the power, 2017-01-20 08:02:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 08:04:08]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484899317940710,
"parent_rev": "cbb8929e97ee475dab4f704a71637e76342e903a", "commit_rev":
"70000946eb2a9155679528702a766219a1fcf154"}

[commit-bot: I haz the power, 2017-01-20 08:04:12]

Description was changed from

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

The spec proposal is not yet final, so this may still change in the future.

BUG=v8:5437
==========

to

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

The spec proposal is not yet final, so this may still change in the future.

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
==========

[commit-bot: I haz the power, 2017-01-20 08:04:13]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...

[jgruber, 2017-01-20 08:41:40]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2643213002/ by jgruber@chromium.org.

The reason for reverting is: Breaks no18n build:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%2....

[jgruber, 2017-01-20 08:43:21]

Description was changed from

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

The spec proposal is not yet final, so this may still change in the future.

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
==========

to

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

The spec proposal is not yet final, so this may still change in the future.

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
==========

[jgruber, 2017-01-20 15:33:07]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 15:33:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-20 15:34:10]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 15:34:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-20 15:39:21]

The CQ bit was unchecked by jgruber@chromium.org

[jgruber, 2017-01-20 15:39:32]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-01-20 15:39:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2630233003/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-20 15:39:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 16:11:13]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484926772337450,
"parent_rev": "24b9fc3a9a42977f58c872d4d99cce92e232650c", "commit_rev":
"ee94fa11ed63477393c6534c352ebac6e502396c"}

[commit-bot: I haz the power, 2017-01-20 16:11:18]

Description was changed from

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

The spec proposal is not yet final, so this may still change in the future.

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
==========

to

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

The spec proposal is not yet final, so this may still change in the future.

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42570}
Committed:
https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e50...
==========

[commit-bot: I haz the power, 2017-01-20 16:11:19]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e50...

[Dan Ehrenberg, 2017-01-20 18:23:47]

https://codereview.chromium.org/2630233003/diff/120001/src/builtins/builtins-...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2630233003/diff/120001/src/builtins/builtins-...
src/builtins/builtins-regexp.cc:277: language_mode);
We should really be calling DefineOwnProperty here, not SetProperty. SetProperty
will invoke setters that a user might define on Object.prototype, which is not
the semantics that I'd expect. Generally, the RegExp part of JS calls
CreateDataProperty, which is based on Define, not Set.

https://codereview.chromium.org/2630233003/diff/120001/src/regexp/regexp-pars...
File src/regexp/regexp-parser.cc (right):

https://codereview.chromium.org/2630233003/diff/120001/src/regexp/regexp-pars...
src/regexp/regexp-parser.cc:774: static const char16_t proto_string[] =
u"__proto__";
Sorry I didn't post this comment earlier, but: If adding the properties is
changed from Set to Define I'm not convinced we need to blacklist __proto__.
Instead, if you have a group named __proto__, it would simply create an own
property named __proto__ and not actually change the underlying [[Prototype]].

[jgruber, 2017-01-20 19:03:01]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2639403008/ by jgruber@chromium.org.

The reason for reverting is: Breaks arm64..

[jgruber, 2017-01-24 08:57:06]

Description was changed from

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

The spec proposal is not yet final, so this may still change in the future.

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42570}
Committed:
https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e50...
==========

to

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

The spec proposal is not yet final, so this may still change in the future.

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42570}
Committed:
https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e50...
==========

[jgruber, 2017-01-24 13:24:28]

On 2017/01/20 19:03:01, jgruber wrote:
> A revert of this CL (patchset #7 id:120001) has been created in
> https://codereview.chromium.org/2639403008/ by mailto:jgruber@chromium.org.
> 
> The reason for reverting is: Breaks arm64..

Fix for the broken arm64 test: https://codereview.chromium.org/2652933002/

[jgruber, 2017-01-25 12:33:24]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 12:33:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-25 12:54:02]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 12:54:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-25 13:03:49]

On 2017/01/24 13:24:28, jgruber wrote:
> On 2017/01/20 19:03:01, jgruber wrote:
> > A revert of this CL (patchset #7 id:120001) has been created in
> > https://codereview.chromium.org/2639403008/ by mailto:jgruber@chromium.org.
> > 
> > The reason for reverting is: Breaks arm64..
> 
> Fix for the broken arm64 test: https://codereview.chromium.org/2652933002/

Patchset 9:

* uses CreateDataProperty instead of SetProperty,
* creates the group object with a null prototype,
* and removes the __proto__ name blacklist.

This should match the spec proposal at
https://tc39.github.io/proposal-regexp-named-groups/ (without @@replace).

I'll reland this tomorrow if no one objects.

[commit-bot: I haz the power, 2017-01-25 13:25:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 13:25:09]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-01-26 07:56:09]

Description was changed from

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

The spec proposal is not yet final, so this may still change in the future.

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42570}
Committed:
https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e50...
==========

to

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

https://tc39.github.io/proposal-regexp-named-groups/

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42570}
Committed:
https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e50...
==========

[jgruber, 2017-01-26 07:57:15]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-01-26 07:57:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2630233003/#ps160001
(title: "Null proto and remove __proto__ blacklist")

[commit-bot: I haz the power, 2017-01-26 07:57:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 07:59:22]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1485417435114920,
"parent_rev": "f1ebb1d9c59778e39eed9f348cbbca294924ba3a", "commit_rev":
"8bf52534f6bf86821a1589dcbcb7335052c1f94f"}

[commit-bot: I haz the power, 2017-01-26 07:59:29]

Description was changed from

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

https://tc39.github.io/proposal-regexp-named-groups/

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42570}
Committed:
https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e50...
==========

to

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

https://tc39.github.io/proposal-regexp-named-groups/

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Original-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Commit-Position: refs/heads/master@{#42570}
Committed:
https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e50...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42676}
Committed:
https://chromium.googlesource.com/v8/v8/+/8bf52534f6bf86821a1589dcbcb7335052c...
==========

[commit-bot: I haz the power, 2017-01-26 07:59:30]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/v8/v8/+/8bf52534f6bf86821a1589dcbcb7335052c...

[Michael Achenbach, 2017-01-26 09:25:19]

Breaks arm64 nosnap:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

Revert again?

[jgruber, 2017-01-26 09:27:53]

On 2017/01/26 09:25:19, Michael Achenbach wrote:
> Breaks arm64 nosnap:
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...
> 
> Revert again?

Seems like several heap tests aren't 100% robust and this CL just exposes these
cases by accident. I already fixed one such case (see above), and I'm currently
looking at this one.

[jgruber, 2017-01-26 09:29:07]

On 2017/01/26 09:27:53, jgruber wrote:
> On 2017/01/26 09:25:19, Michael Achenbach wrote:
> > Breaks arm64 nosnap:
> >
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...
> > 
> > Revert again?
> 
> Seems like several heap tests aren't 100% robust and this CL just exposes
these
> cases by accident. I already fixed one such case (see above), and I'm
currently
> looking at this one.

Not sure I'll get around to landing a fixed test today, let's revert this one to
keep arm64-nosnap green I guess.

[jgruber, 2017-01-26 09:29:58]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2654233002/ by jgruber@chromium.org.

The reason for reverting is: Some heap tests are broken leading to failures on
nosnap builds:

https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

Reverting again until tests are fixed to keep bots green..

[jgruber, 2017-02-01 08:24:46]

Description was changed from

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

https://tc39.github.io/proposal-regexp-named-groups/

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Original-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Commit-Position: refs/heads/master@{#42570}
Committed:
https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e50...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42676}
Committed:
https://chromium.googlesource.com/v8/v8/+/8bf52534f6bf86821a1589dcbcb7335052c...
==========

to

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

https://tc39.github.io/proposal-regexp-named-groups/

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Original-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Commit-Position: refs/heads/master@{#42570}
Committed:
https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e50...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42676}
Committed:
https://chromium.googlesource.com/v8/v8/+/8bf52534f6bf86821a1589dcbcb7335052c...
==========

[jgruber, 2017-02-01 08:25:31]

On 2017/01/26 09:29:58, jgruber wrote:
> A revert of this CL (patchset #9 id:160001) has been created in
> https://codereview.chromium.org/2654233002/ by mailto:jgruber@chromium.org.
> 
> The reason for reverting is: Some heap tests are broken leading to failures on
> nosnap builds:
> 
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...
> 
> Reverting again until tests are fixed to keep bots green..

Test has been fixed in https://codereview.chromium.org/2659573002/, relanding
once more.

[jgruber, 2017-02-01 08:25:46]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-02-01 08:25:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 08:54:38]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1485937546964730,
"parent_rev": "0c3a507b3a92b5fa8a5c6b5b57ce888c2c5fb486", "commit_rev":
"d52ec9e6cfb0c5ad81d614b11957cb85fba06d96"}

[commit-bot: I haz the power, 2017-02-01 08:54:43]

Description was changed from

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

https://tc39.github.io/proposal-regexp-named-groups/

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Original-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Commit-Position: refs/heads/master@{#42570}
Committed:
https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e50...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42676}
Committed:
https://chromium.googlesource.com/v8/v8/+/8bf52534f6bf86821a1589dcbcb7335052c...
==========

to

==========
[regexp] Store named captures on the regexp result

This implements storing named captures on the regexp result object.
For instance, /(?<a>.)/u.exec("b") will return a result such that:

result.group.a  // "b"

https://tc39.github.io/proposal-regexp-named-groups/

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#42532}
Committed:
https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1f...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Original-Commit-Position: refs/heads/master@{#42570}
Committed:
https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e50...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Original-Commit-Position: refs/heads/master@{#42676}
Committed:
https://chromium.googlesource.com/v8/v8/+/8bf52534f6bf86821a1589dcbcb7335052c...
Review-Url: https://codereview.chromium.org/2630233003
Cr-Commit-Position: refs/heads/master@{#42838}
Committed:
https://chromium.googlesource.com/v8/v8/+/d52ec9e6cfb0c5ad81d614b11957cb85fba...
==========

[commit-bot: I haz the power, 2017-02-01 08:54:45]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/v8/v8/+/d52ec9e6cfb0c5ad81d614b11957cb85fba...