Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2654163008: [parser] Skipping inner funcs: add tests for variables called "arguments" (Closed)

Created:
3 years, 10 months ago by marja
Modified:
3 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, adamk, Toon Verwaest, jochen (gone - plz use gerrit)
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Skipping inner funcs: add tests for variables called "arguments" These tests pass without further changes. BUG=v8:5516 Review-Url: https://codereview.chromium.org/2654163008 Cr-Commit-Position: refs/heads/master@{#42762} Committed: https://chromium.googlesource.com/v8/v8/+/0307bbb2a075d18536cfdfb50db5b6fd8a160307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M test/cctest/test-parsing.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
marja
ptal
3 years, 10 months ago (2017-01-27 15:54:48 UTC) #2
vogelheim
lgtm
3 years, 10 months ago (2017-01-27 15:58:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654163008/1
3 years, 10 months ago (2017-01-30 08:38:43 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 09:09:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0307bbb2a075d18536cfdfb50db5b6fd8a1...

Powered by Google App Engine
This is Rietveld 408576698