[parser] Skipping inner funcs: produce correct data for var redeclarations.

[parser] Skipping inner funcs: produce correct data for var redeclarations.

This unifies the behavior of Scope::DeclareVariableName with
Scope::DeclareVariable.

BUG=v8:5516
Review-Url: https://codereview.chromium.org/2658063005
Cr-Commit-Position: refs/heads/master@{#42744}
Committed: https://chromium.googlesource.com/v8/v8/+/53667c89b09cb795b66e56ff8fcd1f691ee7c773

[marja, 2017-01-27 14:09:30]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 14:09:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-01-27 14:10:17]

marja@chromium.org changed reviewers:
+ vogelheim@chromium.org

[marja, 2017-01-27 14:10:17]

vogelheim, ptal

[commit-bot: I haz the power, 2017-01-27 14:44:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 14:44:21]

Dry run: This issue passed the CQ dry run.

[vogelheim, 2017-01-27 15:56:56]

lgtm

https://codereview.chromium.org/2658063005/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2658063005/diff/1/src/ast/scopes.cc#newcode1086
src/ast/scopes.cc:1086: DCHECK(var != kDummyPreParserLexicalVariable);
nitpick: DCHECK_NE (and DCHECK_EQ below).

(Doesn't make much of a difference, admittedly.)

[marja, 2017-01-27 16:00:37]

thanks

https://codereview.chromium.org/2658063005/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2658063005/diff/1/src/ast/scopes.cc#newcode1086
src/ast/scopes.cc:1086: DCHECK(var != kDummyPreParserLexicalVariable);
On 2017/01/27 15:56:56, vogelheim wrote:
> nitpick: DCHECK_NE (and DCHECK_EQ below).
> 
> (Doesn't make much of a difference, admittedly.)

Done.

[marja, 2017-01-27 16:00:41]

The CQ bit was checked by marja@chromium.org

[marja, 2017-01-27 16:00:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2658063005/#ps20001
(title: "code review (vogelheim@)")

[commit-bot: I haz the power, 2017-01-27 16:00:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-01-27 16:01:47]

The CQ bit was unchecked by marja@chromium.org

[marja, 2017-01-27 16:03:00]

The CQ bit was checked by marja@chromium.org

[marja, 2017-01-27 16:03:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2658063005/#ps40001
(title: "moar")

[commit-bot: I haz the power, 2017-01-27 16:03:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 16:33:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485532980134030,
"parent_rev": "aaaffd37581cd4dbaef0391e6475054826de121a", "commit_rev":
"53667c89b09cb795b66e56ff8fcd1f691ee7c773"}

[commit-bot: I haz the power, 2017-01-27 16:33:42]

Description was changed from

==========
[parser] Skipping inner funcs: produce correct data for var redeclarations.

This unifies the behavior of Scope::DeclareVariableName with
Scope::DeclareVariable.

BUG=v8:5516
==========

to

==========
[parser] Skipping inner funcs: produce correct data for var redeclarations.

This unifies the behavior of Scope::DeclareVariableName with
Scope::DeclareVariable.

BUG=v8:5516

Review-Url: https://codereview.chromium.org/2658063005
Cr-Commit-Position: refs/heads/master@{#42744}
Committed:
https://chromium.googlesource.com/v8/v8/+/53667c89b09cb795b66e56ff8fcd1f691ee...
==========

[commit-bot: I haz the power, 2017-01-27 16:33:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/53667c89b09cb795b66e56ff8fcd1f691ee...