Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2654063002: DevTools: migrate TabbedPane chevron over to UI.Icon. (Closed)

Created:
3 years, 11 months ago by lushnikov
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate TabbedPane chevron over to UI.Icon. This patch migrates TabbedPane's chevron icon (the "more tabs" icon) over to UI.Icon. BUG=669323 R=dgozman Review-Url: https://codereview.chromium.org/2654063002 Cr-Commit-Position: refs/heads/master@{#446304} Committed: https://chromium.googlesource.com/chromium/src/+/1e4463e5876e3cba3a597306d7cf93edc2afe5cd

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css View 1 chunk +2 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
lushnikov
please, take a look
3 years, 11 months ago (2017-01-25 07:43:01 UTC) #1
dgozman
lgtm
3 years, 11 months ago (2017-01-25 20:15:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654063002/20001
3 years, 11 months ago (2017-01-26 10:08:31 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 11:51:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1e4463e5876e3cba3a597306d7cf...

Powered by Google App Engine
This is Rietveld 408576698