Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2654043004: DevTools: migrate UI.ViewManager's expand icon over to UI.Icon (Closed)

Created:
3 years, 10 months ago by lushnikov
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate UI.ViewManager's expand icon over to UI.Icon This patch migrates ViewManager's expand icon over to UI.Icon. This is the triangle icon in the "CallStack" sidebar pane title element. BUG=669323 R=dgozman Review-Url: https://codereview.chromium.org/2654043004 Cr-Commit-Position: refs/heads/master@{#446487} Committed: https://chromium.googlesource.com/chromium/src/+/1770ad525ab58b3abad0a40001be00197aae3843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -25 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/View.js View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/viewContainers.css View 1 chunk +1 line, -24 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (11 generated)
lushnikov
please, take a look
3 years, 10 months ago (2017-01-26 00:49:09 UTC) #1
lushnikov
I have a feeling this slipped through your inbox :) bringing it back!
3 years, 10 months ago (2017-01-26 22:50:22 UTC) #10
dgozman
lgtm
3 years, 10 months ago (2017-01-26 23:05:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654043004/1
3 years, 10 months ago (2017-01-26 23:07:07 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 23:13:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1770ad525ab58b3abad0a40001be...

Powered by Google App Engine
This is Rietveld 408576698