Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2653973002: Remove associated interface registration from ChannelProxy (Closed)

Created:
3 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 11 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove associated interface registration from ChannelProxy ChannelProxy already delegates incoming associated interface requests to its Listener if they weren't handled by the Channel. We use this instead of having ChannelProxy register UI-thread-posting binders on the Channel itself. It's simpler and safer this way. BUG=683773 R=jam@chromium.org Review-Url: https://codereview.chromium.org/2653973002 Cr-Commit-Position: refs/heads/master@{#445886} Committed: https://chromium.googlesource.com/chromium/src/+/70bbb59493f1111361e3b1bedd04a14fedb334f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -107 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +15 lines, -11 lines 0 comments Download
M content/child/child_thread_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.cc View 3 chunks +14 lines, -10 lines 0 comments Download
M content/common/associated_interface_registry_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/associated_interface_registry_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ipc/ipc_channel_mojo_unittest.cc View 9 chunks +31 lines, -24 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 4 chunks +5 lines, -28 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 4 chunks +3 lines, -28 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Ken Rockot(use gerrit already)
3 years, 11 months ago (2017-01-24 20:09:19 UTC) #3
jam
lgtm
3 years, 11 months ago (2017-01-25 00:38:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653973002/1
3 years, 11 months ago (2017-01-25 00:40:56 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 00:57:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/70bbb59493f1111361e3b1bedd04...

Powered by Google App Engine
This is Rietveld 408576698