Chromium Code Reviews

Unified Diff: ipc/ipc_channel_proxy.cc

Issue 2653973002: Remove associated interface registration from ChannelProxy (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « ipc/ipc_channel_proxy.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_proxy.cc
diff --git a/ipc/ipc_channel_proxy.cc b/ipc/ipc_channel_proxy.cc
index 3365aef248747a657965bfd82c5751a8e69630b8..91e8236e8cda10d252846175a6a99ca12c129f67 100644
--- a/ipc/ipc_channel_proxy.cc
+++ b/ipc/ipc_channel_proxy.cc
@@ -27,17 +27,6 @@
namespace IPC {
-namespace {
-
-void BindAssociatedInterfaceOnTaskRunner(
- scoped_refptr<base::SingleThreadTaskRunner> task_runner,
- const ChannelProxy::GenericAssociatedInterfaceFactory& factory,
- mojo::ScopedInterfaceEndpointHandle handle) {
- task_runner->PostTask(FROM_HERE, base::Bind(factory, base::Passed(&handle)));
-}
-
-} // namespace
-
//------------------------------------------------------------------------------
ChannelProxy::Context::Context(
@@ -81,9 +70,9 @@ void ChannelProxy::Context::CreateChannel(
associated_group_ = *support->GetAssociatedGroup();
base::AutoLock l(pending_filters_lock_);
- for (auto& entry : pending_interfaces_)
+ for (auto& entry : pending_io_thread_interfaces_)
support->AddGenericAssociatedInterface(entry.first, entry.second);
- pending_interfaces_.clear();
+ pending_io_thread_interfaces_.clear();
}
}
@@ -388,21 +377,13 @@ void ChannelProxy::Context::ClearChannel() {
associated_group_ = mojo::AssociatedGroup();
}
-void ChannelProxy::Context::AddGenericAssociatedInterface(
- const std::string& name,
- const GenericAssociatedInterfaceFactory& factory) {
- AddGenericAssociatedInterfaceForIOThread(
- name, base::Bind(&BindAssociatedInterfaceOnTaskRunner,
- listener_task_runner_, factory));
-}
-
void ChannelProxy::Context::AddGenericAssociatedInterfaceForIOThread(
const std::string& name,
const GenericAssociatedInterfaceFactory& factory) {
base::AutoLock l(channel_lifetime_lock_);
if (!channel_) {
base::AutoLock l(pending_filters_lock_);
- pending_interfaces_.emplace_back(name, factory);
+ pending_io_thread_interfaces_.emplace_back(name, factory);
return;
}
Channel::AssociatedInterfaceSupport* support =
@@ -585,12 +566,6 @@ void ChannelProxy::RemoveFilter(MessageFilter* filter) {
base::RetainedRef(filter)));
}
-void ChannelProxy::AddGenericAssociatedInterface(
- const std::string& name,
- const GenericAssociatedInterfaceFactory& factory) {
- context()->AddGenericAssociatedInterface(name, factory);
-}
-
void ChannelProxy::AddGenericAssociatedInterfaceForIOThread(
const std::string& name,
const GenericAssociatedInterfaceFactory& factory) {
« no previous file with comments | « ipc/ipc_channel_proxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine