Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2653963002: [Experimental] Supporting OOPIF printing

Created:
3 years, 11 months ago by Wei Li
Modified:
3 years, 7 months ago
Reviewers:
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Supporting OOPIF printing. Add a mojo service for pdf composing, and prototype the printing logic to use the service to composite for OOP iframes. The design doc is https://docs.google.com/document/d/1G8DRy1TiEDGWaqDZU9d_7ef8LBCKXVmjkGLxxBPRAoE/edit#bookmark=id.kn1gx6hvg816 (starting from this bookmark only) BUG=455764 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : clean up unused code #

Patch Set 3 : pass handles and added service #

Patch Set 4 : use utility for preview as well #

Patch Set 5 : Simplify with service client library usage and some style fixes #

Patch Set 6 : Attempt to use serivce client class #

Patch Set 7 : set up mojo service and client library #

Patch Set 8 : clean up #

Patch Set 9 : sample paint for subframe #

Patch Set 10 : paint subframe for compositing #

Patch Set 11 : move SkFutureDrawable back to chromium land #

Patch Set 12 : rebase with a couple fixes #

Patch Set 13 : Working, modified painting and messaging #

Patch Set 14 : Print preview works too #

Patch Set 15 : Simplify skia changes #

Patch Set 16 : Rename service, fix for webview, and connect to DiscardableMemoryManager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1900 lines, -181 lines) Patch
M chrome/app/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_manifest_overlay.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/printing/print_composite_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/browser/printing/print_composite_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +69 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_preview_message_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_message_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 8 chunks +98 lines, -20 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 7 chunks +84 lines, -81 lines 0 comments Download
M chrome/utility/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/utility/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +14 lines, -0 lines 0 comments Download
M components/printing/common/print_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +16 lines, -0 lines 0 comments Download
M components/printing/common/print_messages.cc View 1 2 3 4 5 6 2 chunks +3 lines, -1 line 0 comments Download
M components/printing/renderer/print_web_view_helper.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -1 line 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 13 chunks +140 lines, -20 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -4 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_mac.mm View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -3 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_pdf_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +82 lines, -22 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +18 lines, -0 lines 0 comments Download
M content/browser/service_manager/service_manager_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/utility_process_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +33 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +8 lines, -0 lines 0 comments Download
M content/public/app/mojo/content_utility_manifest.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/notification_types.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
A content/public/browser/print_subframe_details.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +20 lines, -0 lines 0 comments Download
M content/public/browser/utility_process_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/renderer/render_frame_observer.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/render_frame_proxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -0 lines 0 comments Download
M printing/pdf_metafile_skia.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +8 lines, -0 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 8 chunks +108 lines, -9 lines 0 comments Download
A services/pdf_compositor/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +41 lines, -0 lines 0 comments Download
A services/pdf_compositor/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +10 lines, -0 lines 0 comments Download
A services/pdf_compositor/README.md View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -0 lines 0 comments Download
A services/pdf_compositor/manifest.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +15 lines, -0 lines 0 comments Download
A services/pdf_compositor/pdf_compositor_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +60 lines, -0 lines 0 comments Download
A services/pdf_compositor/pdf_compositor_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +159 lines, -0 lines 0 comments Download
A services/pdf_compositor/pdf_compositor_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +60 lines, -0 lines 0 comments Download
A services/pdf_compositor/pdf_compositor_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +92 lines, -0 lines 0 comments Download
A services/pdf_compositor/public/cpp/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +17 lines, -0 lines 0 comments Download
A services/pdf_compositor/public/cpp/compositor_data.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +14 lines, -0 lines 0 comments Download
A services/pdf_compositor/public/cpp/pdf_compositor_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +60 lines, -0 lines 0 comments Download
A services/pdf_compositor/public/cpp/pdf_compositor_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +110 lines, -0 lines 0 comments Download
A services/pdf_compositor/public/interfaces/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +21 lines, -0 lines 0 comments Download
A services/pdf_compositor/public/interfaces/OWNERS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -0 lines 0 comments Download
A services/pdf_compositor/public/interfaces/constants.mojom View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +7 lines, -0 lines 0 comments Download
A services/pdf_compositor/public/interfaces/pdf_compositor.mojom View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +20 lines, -0 lines 0 comments Download
M services/service_manager/manifest.json View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -1 line 0 comments Download
M skia/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -0 lines 0 comments Download
A skia/ext/SkFutureDrawable.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +57 lines, -0 lines 0 comments Download
A skia/ext/SkFutureDrawable.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +60 lines, -0 lines 0 comments Download
M skia/ext/skia_utils_base.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +12 lines, -1 line 0 comments Download
M skia/ext/skia_utils_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +23 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrameClient.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrameView.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrameView.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/PrintContext.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/paint/RemoteFramePainter.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/paint/RemoteFramePainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintRecordBuilder.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintRecordBuilder.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameClientImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +14 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebPrintParams.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebRemoteFrameClient.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (7 generated)
Wei Li
Patchset #8 (id:140001) has been deleted
3 years, 10 months ago (2017-02-07 01:42:41 UTC) #1
Wei Li
Description was changed from ========== A prototype for adding pdf composer service. Add a mojo ...
3 years, 10 months ago (2017-02-14 01:09:30 UTC) #2
Wei Li
Description was changed from ========== A prototype for adding pdf composer service. Add a mojo ...
3 years, 10 months ago (2017-02-14 01:14:52 UTC) #3
Wei Li
Description was changed from ========== A prototype for supporting OOPIF printing. Add a mojo service ...
3 years, 10 months ago (2017-02-14 17:50:17 UTC) #4
Wei Li
Description was changed from ========== A prototype for supporting OOPIF printing. Add a mojo service ...
3 years, 10 months ago (2017-02-14 17:54:32 UTC) #5
Wei Li
Description was changed from ========== A prototype for supporting OOPIF printing. Add a mojo service ...
3 years, 9 months ago (2017-03-13 19:01:25 UTC) #6
Wei Li
3 years, 8 months ago (2017-03-28 18:47:00 UTC) #7 
Patchset #16 (id:320001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698