Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: components/printing/renderer/print_web_view_helper_linux.cc

Issue 2653963002: [Experimental] Supporting OOPIF printing
Patch Set: Rename service, fix for webview, and connect to DiscardableMemoryManager Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/printing/renderer/print_web_view_helper_linux.cc
diff --git a/components/printing/renderer/print_web_view_helper_linux.cc b/components/printing/renderer/print_web_view_helper_linux.cc
index f09e4b22c517fac502fc95c710112e474bef9f21..a84cb9b6dd3491f25fad2956498c2d0dd0477557 100644
--- a/components/printing/renderer/print_web_view_helper_linux.cc
+++ b/components/printing/renderer/print_web_view_helper_linux.cc
@@ -64,7 +64,7 @@ bool PrintWebViewHelper::PrintPagesNative(blink::WebLocalFrame* frame,
// blink::printEnd() for PDF should be called before metafile is closed.
FinishFramePrinting();
- metafile.FinishDocument();
+ metafile.FinishAllPages();
#if defined(OS_ANDROID)
int sequence_number = -1;
@@ -84,12 +84,10 @@ bool PrintWebViewHelper::PrintPagesNative(blink::WebLocalFrame* frame,
#else
PrintHostMsg_DidPrintPage_Params printed_page_params;
- if (!CopyMetafileDataToSharedMem(
- metafile, &printed_page_params.metafile_data_handle)) {
+ if (!CopyMetafileDataToSharedMem(metafile, &printed_page_params)) {
return false;
}
- printed_page_params.data_size = metafile.GetDataSize();
printed_page_params.document_cookie = params.params.document_cookie;
for (size_t i = 0; i < printed_pages.size(); ++i) {
« no previous file with comments | « components/printing/renderer/print_web_view_helper.cc ('k') | components/printing/renderer/print_web_view_helper_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698