third_party/WebKit/Source/core/frame/LocalFrame.cpp - Issue 2653963002: [Experimental] Supporting OOPIF printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2653963002: [Experimental] Supporting OOPIF printing

Patch Set: Rename service, fix for webview, and connect to DiscardableMemoryManager Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

index 588507c25ae389c0e2c4265b702a8840cdae3b48..4edfb426b2477fa272d9dc3c18d5c454a6c2491f 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

@@ -614,8 +614,9 @@ bool LocalFrame::shouldUsePrintingLayout() const {

// Only top frame being printed should be fit to page size.

// Subframes should be constrained by parents only.

return document()->printing() &&

- (!tree().parent() || !tree().parent()->isLocalFrame() ||

- !toLocalFrame(tree().parent())->document()->printing());

+ (!tree().parent() ||

+ (tree().parent()->isLocalFrame() &&

+ !toLocalFrame(tree().parent())->document()->printing()));

}

FloatSize LocalFrame::resizePageRectsKeepingRatio(