Convert InlineLoginHandlerImpl to use the new navigation callbacks.

Convert InlineLoginHandlerImpl to use the new navigation callbacks.

BUG=682002
Review-Url: https://codereview.chromium.org/2653953009
Cr-Commit-Position: refs/heads/master@{#446567}
Committed: https://chromium.googlesource.com/chromium/src/+/887fb1be407bf60931bb303610cb6adba27e582d

[jam, 2017-01-26 21:10:59]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 21:11:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-26 21:53:27]

jam@chromium.org changed reviewers:
+ achuith@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:14:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:14:48]

Dry run: This issue passed the CQ dry run.

[achuithb, 2017-01-27 01:11:17]

lgtm with optional nits

https://codereview.chromium.org/2653953009/diff/1/chrome/browser/ui/webui/sig...
File chrome/browser/ui/webui/signin/inline_login_handler_impl.cc (right):

https://codereview.chromium.org/2653953009/diff/1/chrome/browser/ui/webui/sig...
chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:417: if
(!navigation_handle->GetURL().is_empty()) {
Does it make sense to have a stack var for navigation_handle->GetURL()?

https://codereview.chromium.org/2653953009/diff/1/chrome/browser/ui/webui/sig...
File chrome/browser/ui/webui/signin/inline_login_handler_impl.h (right):

https://codereview.chromium.org/2653953009/diff/1/chrome/browser/ui/webui/sig...
chrome/browser/ui/webui/signin/inline_login_handler_impl.h:120: // Overridden
from content::WebContentsObserver overrides.
This comment appears overly verbose if you want to fix it.

[jam, 2017-01-27 01:39:05]

https://codereview.chromium.org/2653953009/diff/1/chrome/browser/ui/webui/sig...
File chrome/browser/ui/webui/signin/inline_login_handler_impl.cc (right):

https://codereview.chromium.org/2653953009/diff/1/chrome/browser/ui/webui/sig...
chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:417: if
(!navigation_handle->GetURL().is_empty()) {
On 2017/01/27 01:11:16, achuithb wrote:
> Does it make sense to have a stack var for navigation_handle->GetURL()?

the getter returns a const reference, so it's the same efficiency as a stack
reference. since it didn't make any lines too long, I didn't create a stack
variable

https://codereview.chromium.org/2653953009/diff/1/chrome/browser/ui/webui/sig...
File chrome/browser/ui/webui/signin/inline_login_handler_impl.h (right):

https://codereview.chromium.org/2653953009/diff/1/chrome/browser/ui/webui/sig...
chrome/browser/ui/webui/signin/inline_login_handler_impl.h:120: // Overridden
from content::WebContentsObserver overrides.
On 2017/01/27 01:11:16, achuithb wrote:
> This comment appears overly verbose if you want to fix it.

Done.

[jam, 2017-01-27 01:39:20]

The CQ bit was checked by jam@chromium.org

[jam, 2017-01-27 01:39:20]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2653953009/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2017-01-27 01:40:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 03:21:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485481160180020,
"parent_rev": "9850866badcafcfd39db10e436217ca0d5bc8826", "commit_rev":
"887fb1be407bf60931bb303610cb6adba27e582d"}

[commit-bot: I haz the power, 2017-01-27 03:22:03]

Description was changed from

==========
Convert InlineLoginHandlerImpl to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert InlineLoginHandlerImpl to use the new navigation callbacks.

BUG=682002

Review-Url: https://codereview.chromium.org/2653953009
Cr-Commit-Position: refs/heads/master@{#446567}
Committed:
https://chromium.googlesource.com/chromium/src/+/887fb1be407bf60931bb303610cb...
==========

[commit-bot: I haz the power, 2017-01-27 03:22:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/887fb1be407bf60931bb303610cb...