Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2653953009: Convert InlineLoginHandlerImpl to use the new navigation callbacks. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
achuithb
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert InlineLoginHandlerImpl to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2653953009 Cr-Commit-Position: refs/heads/master@{#446567} Committed: https://chromium.googlesource.com/chromium/src/+/887fb1be407bf60931bb303610cb6adba27e582d

Patch Set 1 #

Total comments: 4

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/browser/ui/webui/signin/inline_login_handler_impl.h View 1 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
jam
3 years, 11 months ago (2017-01-26 21:53:28 UTC) #4
jam
3 years, 11 months ago (2017-01-26 22:03:36 UTC) #5
achuithb
lgtm with optional nits https://codereview.chromium.org/2653953009/diff/1/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc File chrome/browser/ui/webui/signin/inline_login_handler_impl.cc (right): https://codereview.chromium.org/2653953009/diff/1/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc#newcode417 chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:417: if (!navigation_handle->GetURL().is_empty()) { Does it ...
3 years, 11 months ago (2017-01-27 01:11:17 UTC) #8
jam
https://codereview.chromium.org/2653953009/diff/1/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc File chrome/browser/ui/webui/signin/inline_login_handler_impl.cc (right): https://codereview.chromium.org/2653953009/diff/1/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc#newcode417 chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:417: if (!navigation_handle->GetURL().is_empty()) { On 2017/01/27 01:11:16, achuithb wrote: > ...
3 years, 11 months ago (2017-01-27 01:39:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653953009/20001
3 years, 11 months ago (2017-01-27 01:40:22 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 03:22:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/887fb1be407bf60931bb303610cb...

Powered by Google App Engine
This is Rietveld 408576698