Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.h

Issue 2653953009: Convert InlineLoginHandlerImpl to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_SIGNIN_INLINE_LOGIN_HANDLER_IMPL_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_SIGNIN_INLINE_LOGIN_HANDLER_IMPL_H_
6 #define CHROME_BROWSER_UI_WEBUI_SIGNIN_INLINE_LOGIN_HANDLER_IMPL_H_ 6 #define CHROME_BROWSER_UI_WEBUI_SIGNIN_INLINE_LOGIN_HANDLER_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 // signin flow. 110 // signin flow.
111 std::string auth_code; 111 std::string auth_code;
112 // True if the user wants to configure sync before signing in. 112 // True if the user wants to configure sync before signing in.
113 bool choose_what_to_sync; 113 bool choose_what_to_sync;
114 }; 114 };
115 115
116 static void FinishCompleteLogin(const FinishCompleteLoginParams& params, 116 static void FinishCompleteLogin(const FinishCompleteLoginParams& params,
117 Profile* profile, 117 Profile* profile,
118 Profile::CreateStatus status); 118 Profile::CreateStatus status);
119 119
120 // Overridden from content::WebContentsObserver overrides. 120 // Overridden from content::WebContentsObserver overrides.
achuithb 2017/01/27 01:11:16 This comment appears overly verbose if you want to
jam 2017/01/27 01:39:05 Done.
121 void DidCommitProvisionalLoadForFrame( 121 void DidFinishNavigation(
122 content::RenderFrameHost* render_frame_host, 122 content::NavigationHandle* navigation_handle) override;
123 const GURL& url,
124 ui::PageTransition transition_type) override;
125 123
126 // True if the user has navigated to untrusted domains during the signin 124 // True if the user has navigated to untrusted domains during the signin
127 // process. 125 // process.
128 bool confirm_untrusted_signin_; 126 bool confirm_untrusted_signin_;
129 127
130 base::WeakPtrFactory<InlineLoginHandlerImpl> weak_factory_; 128 base::WeakPtrFactory<InlineLoginHandlerImpl> weak_factory_;
131 129
132 DISALLOW_COPY_AND_ASSIGN(InlineLoginHandlerImpl); 130 DISALLOW_COPY_AND_ASSIGN(InlineLoginHandlerImpl);
133 }; 131 };
134 132
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 std::string password_; 201 std::string password_;
204 std::string session_index_; 202 std::string session_index_;
205 std::string auth_code_; 203 std::string auth_code_;
206 bool choose_what_to_sync_; 204 bool choose_what_to_sync_;
207 bool confirm_untrusted_signin_; 205 bool confirm_untrusted_signin_;
208 206
209 DISALLOW_COPY_AND_ASSIGN(InlineSigninHelper); 207 DISALLOW_COPY_AND_ASSIGN(InlineSigninHelper);
210 }; 208 };
211 209
212 #endif // CHROME_BROWSER_UI_WEBUI_SIGNIN_INLINE_LOGIN_HANDLER_IMPL_H_ 210 #endif // CHROME_BROWSER_UI_WEBUI_SIGNIN_INLINE_LOGIN_HANDLER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698